-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a "version" string into the runtime options, available during execution #1954
Comments
Added Area-Library, Triaged labels. |
This comment was originally written by [email protected] Version numbers typically go major, minor, [point,] revision, and sometimes include a human-readable build tag; it might be worthwhile to include all or several of those. Currently, it'll be most worthwhile to use the revision, I imagine, but if there's ever a "Dart 2" branch, the revision won't be nearly as useful as the major version. |
Removed Type-Defect label. |
Issue #13330 has been merged into this issue. |
The version string is available through the Dart C API (function Dart_VersionString()). In dart:io the version string is also available through Platform.version. |
since this is available in dart:io's Platform, should it also be in dart:html's Platform? Removed Area-Library label. |
For dart2js, this is requesting the version of Dart that it was compiled with? Is this for some form of quirks-mode? Not quite sure that this belongs in the HTML lib- ideally it would be in a location accessible to both. For dart:html's platform, we're trying to avoid version numbers and just expose capabilities. cc @floitschG. |
yeah, I think it would be the Dart SDK version -- so Dartium would be VM version, dart2js would be dart2js version. |
Added this to the Later milestone. |
Dartium is now exposing a "(Dart)" tag in the user agent. It would be super-easy to make that (Dart v8.8.8). Please? |
Removed Area-HTML label. |
Removed this from the Later milestone. |
I think this bug has been misclassified. As stated above, this is functionality for the VM and dart2js not dart:html. Removed Area-Library, Library-Html, Oldschool-Milestone-Later labels. |
cc @lrhn. |
We have 'Platform.version' – for a while now... |
…ath, pool, source_maps, test, tools, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/b08471e..9305d5a): 9305d5a 2023-02-15 Naoto Kaneko Update README.md (#236) characters (https://github.com/dart-lang/characters/compare/29f3a3e..3281cc7): 3281cc7 2023-02-16 Devon Carew blast_repo fixes (#75) dartdoc (https://github.com/dart-lang/dartdoc/compare/3931595..dba6f94): dba6f946 2023-02-16 Janice Collins Preserve type aliases for records in output (#3340) 96e61903 2023-02-16 Sam Rawlins Remove unused additionalOptions parameter, other little refactorings (#3339) f64290e1 2023-02-13 Devon Carew remove an unused css attribute (#3335) c055526a 2023-02-13 Devon Carew fix an issue where we created a temporary directory when performing a dry run (#3334) 1f6c8db5 2023-02-13 dependabot[bot] Bump github/codeql-action from 2.2.1 to 2.2.4 (#3337) f1fa0efc 2023-02-13 dependabot[bot] Bump actions/cache from 3.2.4 to 3.2.5 (#3338) ffi (https://github.com/dart-lang/ffi/compare/69d7596..32f5eef): 32f5eef 2023-02-20 Daco Harkes Bump SDK constraint to 4.0.0 (#185) http (https://github.com/dart-lang/http/compare/f4b365e..c13a3f8): c13a3f8 2023-02-17 Alex Li ✨ Add Cronet embedded tool (#853) markdown (https://github.com/dart-lang/markdown/compare/f51c24c..4befe66): 4befe66 2023-02-16 Zhiguang Chen Do not generate heading IDs for headings with no content in `HeaderWithIdSyntax` (#522) cae08af 2023-02-15 Kevin Moore Prepare to release v7.0.1 (#520) bdbaf76 2023-02-15 Zhiguang Chen Remove lookarounds from autolink extension patterns (#519) eb09fac 2023-02-14 Kevin Moore Move to pkg:dart_flutter_team_lints (#518) 51a6389 2023-02-15 Zhiguang Chen Add line endings to HTML blocks (#512) a4cd7a0 2023-02-14 Kevin Moore Label tests that only run on the VM: allows running tests with browser (#516) 6788042 2023-02-14 Kevin Moore CI: add publish and response workflows (#517) mockito (https://github.com/dart-lang/mockito/compare/d2a8df1..ed5bd84): ed5bd84 2023-01-09 Ross Wang Relax mixin criteria 781752c 2023-02-13 Sam Rawlins Change `void` to `dynamic` when overriding method arguments 71e41b9 2023-02-10 Sam Rawlins Add `ignore_for_file: use_of_void_result` d5a25f8 2023-02-08 Sam Rawlins Fix violations of `unnecessary_parenthesis` lint path (https://github.com/dart-lang/path/compare/a95f1e9..24b58a2): 24b58a2 2023-02-20 Kevin Moore Move to team lints, require Dart 2.19 (#138) 8ec8ca0 2023-02-18 Kevin Moore blast_repo fixes (#137) pool (https://github.com/dart-lang/pool/compare/51f1131..694cfd8): 694cfd8 2023-02-20 Kevin Moore move to package:dart_flutter_team_lints, require Dart 2.19 (#65) 40bf2af 2023-02-20 Kevin Moore blast_repo fixes (#64) source_maps (https://github.com/dart-lang/source_maps/compare/cf44db3..a112e98): a112e98 2023-02-16 Devon Carew configure publishing automation (#74) test (https://github.com/dart-lang/test/compare/b5e70db..e56c643): e56c6439 2023-02-17 Jacob MacDonald Add exe compiler, supports running tests compiled to native executables (#1941) f80dfa00 2023-02-16 Nate Bosch Add note about why we are replacing matcher (#1940) 732ae1de 2023-02-15 Nate Bosch Add `because` usage in examples (#1939) f6df9756 2023-02-15 Jacob MacDonald Fix typo in readme (#1937) aca53419 2023-02-14 Nate Bosch Add a caret constraint for matcher (#1927) f7f3a019 2023-02-14 Jacob MacDonald use test_api/backend.dart instead of test_core/backend.dart (#1936) de40c1c0 2023-02-14 Jacob MacDonald Add support for `--compiler` flag (#1903) 1f42db8c 2023-02-13 Devon Carew updates to package:checks docs (#1933) tools (https://github.com/dart-lang/tools/compare/48a544b..a53933c): a53933c 2023-02-17 Elias Yishak [package:dash_analytics] Tests for conforming to GA4 Measurement Protocol limitations (#9) c54430b 2023-02-17 Devon Carew add some clarification to the top-level readme (#8) webdev (https://github.com/dart-lang/webdev/compare/0bae2be..ae7eb80): ae7eb80 2023-02-17 Anna Gringauze Add tests for object inspection (#1973) 7d80a2c 2023-02-17 Elliott Brooks (she/her) Ignore offset / count if an instance has no `length` (#1972) cd66172 2023-02-17 Elliott Brooks (she/her) [MV3 Debug Extension] User can reload app and continue to debug (#1968) 8b7f9d3 2023-02-16 Anna Gringauze Re-enable weak webdev tests (#1960) 83d8e47 2023-02-16 Elliott Brooks (she/her) [MV3 Debug Extension] Variables in panel.dart should be private (#1969) 4e85e74 2023-02-16 Elliott Brooks (she/her) [MV3 Debug Extension] The new debug extension can be run on Manifest V3 or Manifest V2 (#1966) 3982f5f 2023-02-15 Elliott Brooks (she/her) [MV3 Debug Extension] Clean up tests in preparation for supporting compiling to MV2 (#1964) 3ad544e 2023-02-15 Elliott Brooks (she/her) [MV3 Debug Extension] Remove isMV3Extension field from DevtoolsRequest (#1963) c77043e 2023-02-14 Elliott Brooks (she/her) [MV3 Debug Extension] Fix isDevMode getter (#1962) a761125 2023-02-14 Elliott Brooks (she/her) [MV3 Debug Extension] Print `console` messages on test failure (#1961) 41e92be 2023-02-14 Anna Gringauze Create test_common package (#1945) 443f820 2023-02-14 Anna Gringauze Re-enable skipped reload test (#1958) a7bc3fc 2023-02-14 Anna Gringauze Make dart-uri-file-uri test use sound null safety (#1959) 464a8eb 2023-02-14 Elliott Brooks (she/her) [MV3 Debug Extension] Compile extension with Dart instead of shell script (#1954) 7cf8fe2 2023-02-13 Anna Gringauze Fix asset handler tests (#1956) c371ad7 2023-02-13 Anna Gringauze Fix chrome_proxy_service tests broken after switch to null safety by default (#1957) d6ec127 2023-02-13 Anna Gringauze Move test-only code from the SdkLayout (#1955) 35fa34b 2023-02-13 Elliott Brooks (she/her) [MV3 Debug Extension] Update Chrome APIs to be backwards compatible with MV2 (#1951) Change-Id: I4250594d0fa775d07cb3a0f8594e634552de452b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284240 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/dba6f94..e4cdbd6): e4cdbd6f 2023-02-21 Janice Collins Record rendering simplification (#3344) http (https://github.com/dart-lang/http/compare/c13a3f8..1500a71): 1500a71 2023-02-23 Devon Carew contribute a pull request labeler workflow (#875) e2c4e6f 2023-02-21 Brian Quinlan Add a link to cronet_http_embedded from cronet_http. (#874) markdown (https://github.com/dart-lang/markdown/compare/4befe66..ecbffa9): ecbffa9 2023-02-22 Kevin Moore Use latest lints, require Dart 2.19 or later (#524) shelf (https://github.com/dart-lang/shelf/compare/707c8b2..e3cfe79): e3cfe79 2023-02-22 Devon Carew contribute issue templates and a pull request labeler (#332) test (https://github.com/dart-lang/test/compare/e56c643..2cc4144): 2cc4144e 2023-02-22 Nate Bosch Avoid exceptions for iterable getters (#1954) f7fe4f06 2023-02-22 Nate Bosch Include stack trace for exception in has (#1953) ba8e43af 2023-02-22 Nate Bosch Only grab the first failure in softCheck (#1949) 34df652b 2023-02-22 Nate Bosch Flush stdin before test (#1950) ae015ef6 2023-02-22 Nidal Bakir Add Concurrency Testing section to README (#1944) 4e23d036 2023-02-21 Nate Bosch Mention .having and .has in migration guide (#1948) 438c2274 2023-02-21 Nate Bosch Annotate `has` with `@useResult` (#1947) 3ddecafd 2023-02-21 Nate Bosch Add async examples to README (#1946) tools (https://github.com/dart-lang/tools/compare/a53933c..c7518f7): c7518f7 2023-02-22 Elias Yishak Update to regex to look for underscore delimited labels (#12) webdev (https://github.com/dart-lang/webdev/compare/ae7eb80..1e7f9b7): 1e7f9b7 2023-02-22 Anna Gringauze Create copying sdk configuration provider (#1984) 26910ba 2023-02-22 Anna Gringauze Pass SdkLayout to the frontend server (#1986) 784e28b 2023-02-22 Anna Gringauze Remove unnecessary awaits (#1982) 3cbaf37 2023-02-22 Elliott Brooks (she/her) [MV3 Debug Extension] Support Bolt workflow (#1983) 0f893e6 2023-02-22 Anna Gringauze Move project definitions into a separate class (#1975) a942b5f 2023-02-22 Anna Gringauze Add unnecessary_lambdas lint (#1978) 3774cf8 2023-02-21 Anna Gringauze Add 'avoid_void_async' lint (#1977) 705e0ac 2023-02-21 Elliott Brooks (she/her) [MV3 Debug Extension] Show a warning if multiple Dart apps are in a single page (#1976) Change-Id: Iea264a18a154e71cd0990e1363951648bec5ceba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284940 Reviewed-by: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
This issue was originally filed by @chrisbu
To help with diagnosing issues with third party scripts, it would be useful if those third party scripts could report the version of Dart they are being run with.
Something like (or maybe included in) the RuntimeOptions() class, this would provide information about the dart (or js) runtime being used. I envisage that Frog JS would contain the version of frog that was used to convert to JS.
Eg:
var info = new DartDiags();
print(info.version); //eg: 4567
print(info.envt); //eg: FrogJS, Dartium, DartVM
The text was updated successfully, but these errors were encountered: