Problem with InputStream interface read

[DartBot]

This issue was originally filed by [email protected]

---

Current inputstream interface:

---

interface InputStream {
  /**
   * Reads [len] bytes into [buffer] buffer starting at [offset] offset.
   * [callback] callback is invoked on completion unless it is null.
   */
  bool read(List<int> buffer, int offset, int len, void callback());

  /**
   * Reads data from the stream into a buffer until a given [pattern] occurs and
   * hands that buffer over as an input to the registered [callback].
   * The callback is not invoked if a read error occurs.
   */
  void readUntil(List<int> pattern, void callback(List<int> buffer));
}

---

In an example I'm doing a file read, and this is seems odd to me.

* This is an async operation - what does the return bool mean?

* The callback should take a parameter (int numBytesRead).

I suppose there is a dual in outputstream.

/Karl

[DartBot]

This comment was originally written by [email protected]

---

Added Area-Library, Triaged labels.

[sgjesse]

The streams interfaces are currently being reworked. The first of a series of changes was landed in https://code.google.com/p/dart/source/detail?r=747.

We are currently looking into adding an "end" event to signal end of stream instad of only having the "close" event as some streams e.g. a file input stream does not have a natural close event.

We are also looking at adding a "chunk size" to indicate that one is only interested in "data" events if at least a given number of bytes are available.

The output stream will also be reworked.

Please follow these changes and provide feedback.

---

Set owner to @sgjesse.
Added Accepted label.

[sgjesse]

Issue #181 has been merged into this issue.

[sgjesse]

There is now a proposed update to the input stream interface, see http://codereview.chromium.org/8698018/

[sgjesse]

The input stream and the wrappings string input stream and chunked input stream have now been redesigned.

All streams now have callback which is set using setters and separate read (in various versions) to read data. All read operations return "immediately" with data is available or null if not. The idea is to use the callbacks to get notified when calling read will be guaranteed to return data.

Please open new bugs if you find issues with the new input stream interface.

---

Added Fixed label.