-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dartdoc: add libraries by their real filename #2230
Comments
This comment was originally written by [email protected] typo: lang/world.dart should be frog/world.dart |
This comment was originally written by [email protected] add a screenshot Attachment: |
Removed Area-Frog label. |
Removed OldAreaFrog label. |
This manifests as a dartdoc issue. Categorizing as such. Removed Area-Dart2JS, FromAreaFrog labels. |
Fixed by http://codereview.chromium.org/10701091/ Added Fixed label. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/e96fbdb..babf5d1): babf5d1 2023-09-13 Devon Carew add additional lints to dart_flutter_team_lints (#167) 7740bef 2023-09-13 Moritz Write comments on forks for `firehose` (#165) http (https://github.com/dart-lang/http/compare/de19214..e19094a): e19094a 2023-09-14 Brian Quinlan Use efficient operations when copying bytes between Dart and Java (#1019) d7e4375 2023-09-13 Parker Lougheed Cleanup `package:http` utils (#1011) eafbbb0 2023-09-12 Brian Quinlan Separate the cronet callbacks from the `send` method (#1017) 2cbb703 2023-09-12 Brian Quinlan Switch `cronet_http` to use jnigen (#1016) native (https://github.com/dart-lang/native/compare/bbcbc1f..7faf62c): 7faf62c 2023-09-14 Gabriel Terwesten Add `includes`, `flags`, `std`, `language`, `cppLinkStdLib` options (#125) shelf (https://github.com/dart-lang/shelf/compare/2926f76..e2a02b7): e2a02b7 2023-09-13 Kevin Moore Move to latest pkg:dart_flutter_team_lints, bump min sdk to Dart 3 (#378) tools (https://github.com/dart-lang/tools/compare/fa01f9b..1512f3d): 1512f3d 2023-09-13 Elias Yishak Add Fake Analytics instance that uses list to save events sent (#149) webdev (https://github.com/dart-lang/webdev/compare/6b21ecf..501ccc2): 501ccc28 2023-09-12 Elliott Brooks Update DCM triggers to match Dart DevTools (#2230) Change-Id: Ic3dc1924da48454a28e4c0d8705244ac1565e74a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325967 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was originally filed by [email protected]
This came up with dartdoc.dart (bleeding_edge, r 5635)
In dartdoc the docIndex method creates a listing of the processed libraries (stored in _sortedLibraries). Currently the 'uri' entry is displayed twice.
The problem is in lang/world.dart > getOrAddLibrary(filename), where processing of filenames 'dart:uri' and '../../lib/uri/uri.dart' leads to 2 entries in the libraries array.
Using the attached patch i first sort of normalize the filename and then process the file.
Attachment:
world.dart.patch (637 Bytes)
The text was updated successfully, but these errors were encountered: