Handling of missing 'len' parameter in OutputStream.writeFrom

[DartBot]

This issue was originally filed by [email protected]

---

The new OutputStream interface contains the following code:

/**
 * Writes [len] bytes from buffer [buffer] starting at offset
 * [offset] to the output stream. If [offset] is not specified the
 * default is 0. If [len] is not specified the default is the length
 * of the buffer passed. The system will copy the data to be written
 * so the caller can safely change [buffer] afterwards. Returns true
 * if the data could be written to the underlying communication
 * channel immediately. Otherwise the data is buffered by the output
 * stream and will be sent as soon as possible.
 */
bool writeFrom(List<int> buffer, [int offset, int len]);

It seems like it would be more useful for the value of len (if not supplied) to be equal to (buffer.length - offset) rather than buffer.length. Thus would allow 'writeFrom(buf, offset)' to mean 'write the portion of the buffer from offset forward', whereas in the current scheme it will always result in an IndexOutOfRangeException when offset > 0.

[whesse]

cc @madsager.
Set owner to @sgjesse.
Added Accepted label.

[sgjesse]

Proposed change in http://codereview.chromium.org/8493002/.

[sgjesse]

Committed: https://code.google.com/p/dart/source/detail?r=1293

---

Added Fixed label.