Rename Date.fromString to Date.parse #3068
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
type-enhancement
A request for a change that isn't a bug
Comments
|
cc @floitschG. |
|
This comment was originally written by @seaneagan Actually, if this constructor is going to continue only taking ISO-8601 Strings, then Date.fromIso or Date.fromIso8601 might be better names. |
|
I really want to keep the constructor simple (and well specified) and defer more complicated parsing to an i80n library. |
|
It is now Date.parse. Added Fixed label. |
DartBot
added
Type-Enhancement
area-core-library
kevmoo
added
type-enhancement
copybara-service bot
pushed a commit
that referenced
this issue
Jul 5, 2022
…4 revisions) https://dart.googlesource.com/dartdoc/+log/900432d8cb1e..21f9341eb662 2022-07-05 [email protected] Switch to analyzer's updateAnalysisOptions2 (#3068) 2022-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.1.1 to 1.1.2 (#3067) 2022-07-05 [email protected] bumped analyzer version to 4.0.0 (#3033) 2022-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.14 to 2.1.15 (#3066) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I6abe8e224af5682f96a7624e5b24a4921bf6c890 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250701 Commit-Queue: Kevin Moore <[email protected]> Commit-Queue: DEPS Autoroller <[email protected]> Reviewed-by: Kevin Moore <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by @seaneagan
'parse' is at least as clear as 'fromString' yet shorter.
should be considered in the context of issue #2868 and issue #2870.
The text was updated successfully, but these errors were encountered: