Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Dart Editor version information for dartlang.org download page #3196

Closed
DartBot opened this issue May 24, 2012 · 18 comments
Closed

Provide Dart Editor version information for dartlang.org download page #3196

DartBot opened this issue May 24, 2012 · 18 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug
Milestone

Comments

@DartBot
Copy link

DartBot commented May 24, 2012

This issue was originally filed by [email protected]


Please provide us with a versionnumber or a buildnumber in the ZIP-filename for download.
Right now it jus says something like: dart-editor-macosx.cocoa.x86_64.zip

In the current situation where things change so fast I am never sure if I already have the latest version or not.
A buildnumber or a remark on the download-page would solve this problem.

@kasperl
Copy link

kasperl commented May 24, 2012

Added Area-Editor, Triaged labels.

@danrubel
Copy link

Set owner to @danrubel.

@kevmoo
Copy link
Member

kevmoo commented May 30, 2012

Agreed. Version number on the zip would be awesome

And/or a version.txt file of some such in the zip would be great, too

@danrubel
Copy link

danrubel commented Jun 5, 2012

We plan to generate version information in a file for the dartlang.org download page to consume/display.


Added this to the M1 milestone.
Changed the title to: "Provide Dart Editor version information for dartlang.org download page".

@pq
Copy link
Member

pq commented Jul 2, 2012

Set owner to @pq.
Added Accepted label.

@pq
Copy link
Member

pq commented Jul 3, 2012

A simple VERSION file is now being created and uploaded as part of the editor build process. For example:

http://commondatastorage.googleapis.com/dart-editor-archive-continuous/latest/VERSION

Currently it only contains the build id. Open for discussion is whether this should contain more data and/or being in a standard format (e.g., JSON).


cc @sethladd.
Added Started label.

@sethladd
Copy link
Contributor

sethladd commented Jul 9, 2012

It would be very nice to also include a "Built on YYYY-MM-DD" in the VERSION file.

@sethladd
Copy link
Contributor

sethladd commented Jul 9, 2012

A JSON file with build metadata would be HOT. To do this, you'll have to turn on CORS headers for your download location (I don't have access, but it's not hard: https://developers.google.com/storage/docs/cross-origin )

Potential information to include:

  • Build number
  • Date (in YYYY-MM-DDTHH:MM:SS format)
  • Integration or Continuous
  • OS
  • 64 or 32bit

Thanks!
Seth

@sethladd
Copy link
Contributor

sethladd commented Jul 9, 2012

If you make this a JSON file and enable the CORS headers, I can consume from Dart (natively or when compiled to JS)

@pq
Copy link
Member

pq commented Jul 9, 2012

Since one VERSION file describes all the build artifacts for a given build the JSON can't sensibly carry OS or arch details in its payload. Luckily both can be inferred from the artifact names. Integration vs. Continuous is also out since that's not known at build time when the file is created. That said, we can fetch this from the bucket name so not all is lost.

For starters, it looks like we've for a build number and date. Let's start spitballing formats. To kick it off, what about:

{"build" : {
  "id" : "1234",
  "date" : "2012-07-09" <-- is day enough?
  }
}

@sethladd
Copy link
Contributor

sethladd commented Jul 9, 2012

Day is fine, yup. Since we can infer the rest of the information from the filename or bucket name, lgtm.

Kathy brings up a good point: version number, eg X.Y.Z. We'd want that included at some point, too.

@pq
Copy link
Member

pq commented Jul 10, 2012

Cool.

Here's where we're heading:

{
  "revision" : "9826",
  "version" : "0.0.1_v2012070961811",
  "date" : "2012-07-09"
}

CL in flight: http://codereview.chromium.org/10689140/

@pq
Copy link
Member

pq commented Aug 15, 2012

Basic version contents are being generated. See, for example:

http://commondatastorage.googleapis.com/dart-editor-archive-integration/latest/VERSION

I believe the last remaining bit is setting up the right CORS settings for the GS bucket.

Seth: could you update with status? Thanks!


Removed Type-Defect label.
Added Type-Enhancement label.

@sethladd
Copy link
Contributor

cc @pq.
Set owner to @sethladd.
Removed Area-Editor label.
Added Area-Site label.

@sethladd
Copy link
Contributor

Here's the CORS config for cloud storage:

<?xml version="1.0" ?>
<CorsConfig>
    <Cors>
        <Origins>
            <Origin>*</Origin>
        </Origins>
        <Methods>
            <Method>GET</Method>
            <Method>HEAD</Method>
        </Methods>
    </Cors>
</CorsConfig>

@sethladd
Copy link
Contributor

@sethladd
Copy link
Contributor

Added Fixed label.

@nicolasgarnier
Copy link
Contributor

This issue has been moved to Github as part of a migration. Please use the Issue on Github going forward: https://github.com/dart-lang/dartlang.org/issues

@DartBot DartBot added this to the M1 milestone Aug 26, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Nov 25, 2022
Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53

Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667)
 https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196)
 https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666)
 https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665)
 https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656)
 https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to
override stdout.hasTerminal for output animations (#3658)
 https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663)
 https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571)
 https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637)
 https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660)
 https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650)
 https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652)
 https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648)

```

Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/

Bump webdev to 637b406f325669507b5c1048c19a7c0083c1bd6e

Changes:
```
> git log --format="%C(auto) %h %s" 3ec168f..637b406
 https://dart.googlesource.com/webdev.git/+/637b406 Support `--native-assets` in `FrontendServerClient` (#1797)
 https://dart.googlesource.com/webdev.git/+/a19d563 Save debug information in `chrome.storage` after a Dart app loads  (#1791)
 https://dart.googlesource.com/webdev.git/+/9cc10d4 Connect to a `chrome.runtime` port to keep the service worker alive  (#1789)

```
Diff: https://dart.googlesource.com/webdev.git/+/3ec168f6815af9d5f11278111d147bc82c0755c3~..637b406f325669507b5c1048c19a7c0083c1bd6e/


Update CHANGELOG


Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53

Changes:
```
> git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4
 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667)
 https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196)
 https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666)
 https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665)
 https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656)
 https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to override stdout.hasTerminal for output animations (#3658)
 https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663)
 https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571)
 https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637)
 https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660)
 https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650)
 https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652)
 https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648)

```

Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/
Change-Id: I65b928479b44f08305853078b0f34a6b66602709
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271709
Auto-Submit: Sigurd Meldgaard <[email protected]>
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants