Two forms of string interpolation are not equal

[DartBot]

This issue was originally filed by [email protected]

---

The Dart spec v009, 10.5.1 String Interpolation reads:

The form $id is equivalent to the form ${id}

Consider following test:

void id(){}

main() {
  Expect.stringEquals('${id}', '$id');
}

Dart vm (revision 8274) accepts the form '${id}' but rejects the form '$id':

 illegal reference to method 'id'
  Expect.stringEquals('${id}', '$id');
                                ^

[DartBot]

This comment was originally written by [email protected]

---

That's a nice catch! Here's my hacky patch that fixes the issue. Proper fix should add a test (I didn't even run those existing, but from my understanding of the parser code, this change can't affect anything else than the simple case of string interpolation) and do some renaming, but that's less fun :-)

---

Attachment:
0001-fix-issue-3390.patch (3.44 KB)

[madsager]

Added Area-VM, Triaged labels.
Changed the title to: "Two forms of string interpolation are not equal".

[iposva-google]

We should make sure that the simplified version of string interpolation really is just a short-hand for the full interpolation. Carl, can you take a look?

---

Set owner to @lexprfuncall.
Added Accepted label.

[lexprfuncall]

I looked at this and the reported issue does reproduce. I reviewed this with Matthias and we believe ParseLiteral is behaving in error. It is not year clear what the scope of the fix should be.

---

Set owner to @mhausner.

[DartBot]

This comment was originally written by @mhausner

---

ladicek's patch would work. I have a fix that essentially does the same thing but handles the closurization at the call site.

[DartBot]

This comment was originally written by @mhausner

---

This should be fixed in r8956. I ended up using an extra parameter just as ladicek suggested. Thank you for that patch!

Also added a test case in language/string_interpolation_test_01.dart

One co19 test was wrong, filed co19 issue #152.

---

Added Fixed label.