-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mangle names of function parameters. #3398
Labels
P1
A high priority bug; for example, a single project is unusable or has many test failures
web-dart2js
Comments
Set owner to [email protected]. |
This comment was originally written by [email protected] Fixed in https://chromiumcodereview.appspot.com/10543050/. Added Fixed label. |
karlklose
added
Type-Defect
P1
A high priority bug; for example, a single project is unusable or has many test failures
web-dart2js
labels
Jun 7, 2012
copybara-service bot
pushed a commit
that referenced
this issue
May 16, 2023
…ctor, browser_launcher, characters, cli_util, clock, collection, crypto, dartdoc, leak_tracker, lints Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/1864048..f0f6cd2): f0f6cd2 2023-05-12 Devon Carew blast_repo fixes (#243) async (https://github.com/dart-lang/async/compare/0f368d3..d744058): d744058 2023-05-12 Devon Carew blast_repo fixes (#242) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/1b86d3c..d9b389f): d9b389f 2023-05-12 Devon Carew blast_repo fixes (#73) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f81b042..e717ad4): e717ad4 2023-05-12 Devon Carew blast_repo fixes (#90) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/7eed402..3a1c982): 3a1c982 2023-05-15 Devon Carew Update README.md (#48) 23e08e0 2023-05-12 Devon Carew blast_repo fixes (#47) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/551e101..40e4315): 40e4315 2023-05-12 Devon Carew blast_repo fixes (#45) characters (https://github.com/dart-lang/characters/compare/2af6783..3ef8883): 3ef8883 2023-05-15 Devon Carew blast_repo fixes (#82) cli_util (https://github.com/dart-lang/cli_util/compare/7234f17..5a49947): 5a49947 2023-05-15 Devon Carew blast_repo fixes (#83) clock (https://github.com/dart-lang/clock/compare/6b9df3e..fe85908): fe85908 2023-05-15 Devon Carew blast_repo fixes (#51) collection (https://github.com/dart-lang/collection/compare/6abff47..db2da48): db2da48 2023-05-15 Devon Carew blast_repo fixes (#288) crypto (https://github.com/dart-lang/crypto/compare/4e9dde1..216931a): 216931a 2023-05-15 Devon Carew blast_repo fixes (#149) dartdoc (https://github.com/dart-lang/dartdoc/compare/d01ddc5..2952f6b): 2952f6bf 2023-05-16 Sam Rawlins Simplify ToolConfiguration and other options code (#3414) 0cf21c15 2023-05-12 Janice Collins Extract fileName / fileType from ModelElement, LibraryContainer into FileStructure (#3413) 2ae78bcc 2023-05-12 Sam Rawlins Split sidebars out into separate HTML files (#3384) f00d0443 2023-05-11 Janice Collins Housekeeping: language version 3.0, analyzer deprecations, pubspec update (#3412) 370477d2 2023-05-10 dependabot[bot] Bump github/codeql-action from 2.3.2 to 2.3.3 (#3410) e8c5de44 2023-05-08 Janice Collins Begin extracting file structure information from ModelElement (#3408) 24af8a11 2023-05-04 Janice Collins Add a hideConstantImplementations dartdoc directive (#3398) 078d42fd 2023-05-03 Janice Collins Change language feature wording based on review in #3401 (#3405) 31088c1b 2023-05-03 dependabot[bot] Bump github/codeql-action from 2.2.12 to 2.3.2 (#3403) 60055b4e 2023-05-03 Sam Rawlins Update validate-sdk-docs task to allow 20 libs (#3404) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/bc7f604..8ae200a): 8ae200a 2023-05-15 Polina Cherkasova - (#62) lints (https://github.com/dart-lang/lints/compare/17276ec..72f107a): 72f107a 2023-05-15 Devon Carew blast_repo fixes (#120) 6732fbc 2023-05-15 Devon Carew blast_repo fixes (#119) Change-Id: Ibbb1fcc530da01653fe325bdcf77f1c764887a81 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303783 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P1
A high priority bug; for example, a single project is unusable or has many test failures
web-dart2js
Parameter names are not mangled and can conflict with source identifiers.
Dart:
void show(final String t0) {
assert (null !== t0 && 0 !== t0.length);
document.query('#status').innerHTML = t0;
}
is compiled to:
$.show = function(t0) {
var t0 = !((void 0) === t0);
if (t0) {
var t1 = !(0 === $.get$length(t0));
} else {
t1 = t0;
}
$.assert(t1);
$.document().query$1('#status').set$innerHTML(t0);
};
The text was updated successfully, but these errors were encountered: