Library[1,4,5,6]NegativeTest is overly restrictive

[DartBot]

This issue was originally filed by [email protected]

---

These 4 tests check for conflicting names - but never actually reference those names. These tests should be allowed to pass unless the --compile_all flag is used to force full compilation and checking. These tests can all be trivially fixed by adding a reference in code (reachable from main) to the offending names.

This issue is equivalent to the one addressed in this commit (with accompanying code review discussion):
  http://code.google.com/p/dart/source/detail?spec=svn1233&r=1055

[DartBot]

This comment was originally written by [email protected]

---

Test TypeVariableBoundsTest/05 appears to share roughly the same issue - where it is expecting a compile-time error from a member that is never invoked.

[DartBot]

This comment was originally written by [email protected]

---

And two more tests that appear to be the same issue:

Field3NegativeTest
FieldNegativeTest

FieldOverrideTest has the slightly more complicated version where the types are instantiated, but the invalid field (named 'field') is not ever referenced which I believe should also be within the legal bounds of a compile without --compile_all.

[DartBot]

This comment was originally written by [email protected]

---

Added Area-Frog, Triaged labels.

[dgrove]

Removed Area-Frog label.
Added Area-Test label.

[iposva-google]

I reviewed these Library*NegativeTests with Gilad and they appear to be correct.

---

Removed Area-Test label.
Added Area-Frog label.

[DartBot]

This comment was originally written by [email protected]

---

I'm going to close this as resolved. The issue was a test issue and has been resolved as the tests are correct. The frog issue is captured clearly enough by language.status.

---

Removed Priority-High, Area-Frog labels.
Added Priority-Medium, Area-Test, Invalid labels.