Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in latest pub #36026

Closed
kevmoo opened this issue Feb 26, 2019 · 6 comments
Closed

Bring in latest pub #36026

kevmoo opened this issue Feb 26, 2019 · 6 comments
Assignees
@sigurdm
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P2 A bug or feature request we're likely to work on
Milestone
Dart 2.2.1

Comments

@kevmoo
Copy link
Member

kevmoo commented Feb 26, 2019

The last sync of pub was on Aug 8 - dart-lang/pub@9f00679

We've had a number of commits since – dart-lang/pub@SDK-2.1.0-dev.1.0...master – and we've added a changelog validaor, logout command, support for global activation via a custom pub URL, etc.

It'd be nice to roll this in, no?

CC @mit-mit @sigurdm
@kevmoo kevmoo added area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P2 A bug or feature request we're likely to work on labels Feb 26, 2019
@kevmoo kevmoo added this to the Dart2.2 milestone Feb 26, 2019
@kevmoo kevmoo mentioned this issue Feb 26, 2019
Closed
@mit-mit
Copy link
Member

mit-mit commented Feb 26, 2019

Too late for 2.2; that is going out today. But, yes we should bring this over.

@mit-mit mit-mit modified the milestones: Dart2.2, Dart2.2.1 Feb 26, 2019
@sigurdm
Copy link
Contributor

sigurdm commented Feb 26, 2019

I've created https://dart-review.googlesource.com/c/sdk/+/94380

@sigurdm sigurdm self-assigned this Feb 26, 2019
@kevmoo
Copy link
Member Author

kevmoo commented Feb 27, 2019

Before we close out this issue, can we do another sync? ...to grab dart-lang/pub#2014

@kevmoo kevmoo mentioned this issue Feb 27, 2019
Merged
@sigurdm
Copy link
Contributor

sigurdm commented Feb 28, 2019

https://dart-review.googlesource.com/c/sdk/+/94744

dart-bot pushed a commit that referenced this issue Feb 28, 2019
@sigurdm
Sync pub client to newest version
895bc90 
```
git log --oneline --no-decorate 980fc947db32bca6ae7d07fbb4ad0fcdba0050ec..3c060aae47985e9a248b850f1d0450304a5c97e3
3c060aae Usage: pub global activate <package> [version-constraint] (#2051)
93783b60 Improve the error when encountering a non-local package with a path dep
2b4056b0 Lint tweaks for Dart 2.2
135e10af Update last modified date directly in `touch` (#2014)
```

No relevant changes for the changelog

Bug: #36026
Change-Id: I2dcaad614f5fbd511712d4713c7b008d7ff710f1
Reviewed-on: https://dart-review.googlesource.com/c/94744
Reviewed-by: Jonas Jensen <[email protected]>
Commit-Queue: Sigurd Meldgaard <[email protected]>
@vsmenon
Copy link
Member

vsmenon commented Mar 13, 2019

Is this still open?

@kevmoo
Copy link
Member Author

kevmoo commented Mar 13, 2019

Fixed in 895bc90

@kevmoo kevmoo closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigurdm sigurdm

Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
Dart 2.2.1
Development

No branches or pull requests
4 participants
@kevmoo @vsmenon @sigurdm @mit-mit