Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All VM classes used at runtime (type checks, instance of) should be finalized. #364

Closed
ghost opened this issue Nov 7, 2011 · 2 comments
Closed

All VM classes used at runtime (type checks, instance of) should be finalized. #364

ghost opened this issue Nov 7, 2011 · 2 comments
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@ghost
Copy link

ghost commented Nov 7, 2011

Some of the VM internal classes are nto finalized. Add ASSERT(cls.is_finalized()) to TypeCheck in error.cc to catch the list.
@DartBot
Copy link

DartBot commented Nov 8, 2011

This comment was originally written by [email protected]

Added Triaged label.

@crelier
Copy link
Contributor

crelier commented Nov 9, 2011

Fixed in r1380.

Added Fixed label.

@ghost ghost added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Nov 9, 2011
@ghost ghost assigned crelier Nov 9, 2011
dart-bot pushed a commit that referenced this issue Jun 12, 2019
@athomas
[co19] Roll co19 to cd1be9d07df32413024fe5c4ae9c5c6017c2f2c8
299532d 
2019-06-11 [email protected] More fixes to cast response to Stream<List<int>> (#385)
2019-06-11 [email protected] Pass Uint8List to Datagram (#382)
2019-06-11 [email protected] Cast HttpRequest and HttpClientResponse streams to List<int> (#384)
2019-06-10 [email protected] Fixes #364. Change expected result to null for default values of clientMaxWindowBits and serverMaxWindowBits
2019-06-07 [email protected] Fixes #380. Added tests for logical and bitwise operations via type aliases
2019-06-07 [email protected] Additional fix for #373. Code style improved and more strict pattern checking
2019-06-06 [email protected] Fix for #380. Added tests for type aliases for built-in types. Test string concatenation and arithmetic operations
2019-06-05 [email protected] Fixes #380. Added tests for type aliases for built-in types initialization
2019-06-05 [email protected] Fixes #373. Expect reasonable file mode on Unix
2019-06-04 [email protected] Fixes #379. Numerous fixes for io/Process tests
2019-06-04 [email protected] Fixes #378. Use Platform.resolvedExecutable instead of 'dart' command
2019-06-04 [email protected] Fixed Issue #375: it's possible that IPv6 loopback does not exist.
2019-06-04 [email protected] Fixed Issue #236: host.host can be either "localhost" or Platform.localHostname.
2019-06-04 [email protected] Issue #370, instantiate-to-bounds: added static tests for non-function type aliases.
2019-06-04 [email protected] Fix for #377. Use correct network interface type name (IPvX)
2019-06-04 [email protected] Fixes #374. Change pattern for error messages
2019-06-04 [email protected] Issue #370, instantiate-to-bounds: added dynamic tests for non-function type aliases.
2019-06-04 [email protected] Fix for #372. Expect.fail() on timeout added
2019-06-04 [email protected] Fixes #371. Remove excessive asyncStart()
2019-06-03 [email protected] Issue #147, test super bounded types: added tests for non-function type aliases.
2019-05-30 [email protected] Fixes #369. Use correct type arguments to avoid errors
2019-05-30 [email protected] Fixes #368. Don't try to bind system port
2019-05-30 [email protected] Fixes #367. Remove excessive asyncStart()
2019-05-30 [email protected] Fixes #366. Change expected result to SocketException

[email protected]

Change-Id: I137689755907b3333e597d7d210db2b4d37d70d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105641
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: William Hesse <[email protected]>
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crelier @DartBot