Exception throw in child isolate crashes Dartium

[kevmoo]

What steps will reproduce the problem?

1. Check out the gist: https://gist.github.com/2945042
2. Notice I forget to add the SendPort in the mouse move handler (line 25)
3. Line 33 will fail as you'd expect with an un-set 'replyTo'
4. But, the Dartium tab crashes (not as you'd expect)

What is the expected output? What do you see instead?
Some helpful error message

What version of the product are you using? On what operating system?
8832

[DartBot]

This comment was originally written by [email protected]

---

Added this to the M1 milestone.
Added Area-Dartium, Accepted labels.

[DartBot]

This comment was originally written by [email protected]

---

Changed the title to: "Exception throw in child isolate crashes Dartium".

[kevmoo]

What is the expected behavior here?

In the case of SendPort.call, I'd hope the associated future will party with the associated handleException, etc.

Right?

I was hoping that wiring up handleException would save me from a crash. Sadly, no.

[DartBot]

This comment was originally written by [email protected]

---

Issue #2035 has been merged into this issue.

[DartBot]

This comment was originally written by [email protected]

---

Set owner to [email protected].

[DartBot]

This comment was originally written by [email protected]

---

So the analysis.

I am not aware of scenarios when it's a problem with DOM isolates as on all the entry points we check returned value and report any unhandled exceptions.

It's easily reproducible for pure Dart isolates and in this case we end up in ShutdownIsolate (of lib/isolate.cc) which invokes exit(255) and that awsnaps the tab.

Looks like we need something in embedder API to prevent this exit call and ideally some hook to properly report unhandled exception which led to isolate termination.

Marking as Area-VM and tentatively assigning to Todd. Please, assign back to me once there is a way to solve the problem in Dartium.

---

cc @iposva-google.
Set owner to @turnidge.
Removed Area-Dartium label.
Added Area-VM label.

[justinfagnani]

Issue #2035 has been merged into this issue.

[iposva-google]

Removed this from the M1 milestone.
Added this to the M2 milestone.

[iposva-google]

Removed this from the M2 milestone.
Added this to the M3 milestone.

[iposva-google]

Removed this from the M3 milestone.
Added this to the M4 milestone.

[larsbak]

Removed this from the M4 milestone.
Added this to the M5 milestone.

[iposva-google]

Removed Priority-Medium label.
Added Priority-Unassigned label.

[iposva-google]

Removed this from the M5 milestone.

[iposva-google]

Siva is this still happening? I remember we did add special handling for unhandled exceptions.

---

Set owner to @a-siva.
Removed Area-VM label.
Added Area-Dartium label.

[a-siva]

We don't get a Dart tab crash now, the following error message is what we get and the child isolate is terminated due to this unhandled exception.

in ShutdownIsolate: Unhandled exception:
The null object does not have a method 'send'.

NoSuchMethodError : method not found: 'send'
Receiver: null
Arguments: ["yo!"]
#­0 Object.noSuchMethod (dart:core-patch/object_patch.dart:20:25)
#­1 childIsolate.<anonymous closure> (file:///usr/local/google/home/asiva/Downloads/async_demo.dart:26:17)
#­2 _ReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:81:92)
#­3 childIsolate.<anonymous closure> (file:///usr/local/google/home/asiva/Downloads/async_demo.dart:26:17)
#­4 _ReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:81:92)

---

Added Fixed label.