Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dart:mirrors and tests to NNBD #40045

Closed
leafpetersen opened this issue Jan 9, 2020 · 4 comments
Closed

Migrate dart:mirrors and tests to NNBD #40045

leafpetersen opened this issue Jan 9, 2020 · 4 comments
Assignees
@rmacnak-google
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Milestone
D28 Release

Comments

@leafpetersen
Copy link
Member

Sub issue of #38037 .
@leafpetersen leafpetersen added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release labels Jan 9, 2020
@leafpetersen
Copy link
Member Author

Migration instructions here.

dart-bot pushed a commit that referenced this issue Jan 15, 2020
@rmacnak-google
[vm] Update dart:mirrors for Dart 3.
e0c366a 
Also back-ports all non-type changes to the Dart 2 version for the sake of testing.

Bug: #40045
Change-Id: Idda6b6c5e8508efe4db79f27f41d0a2485b9f197
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131485
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@a-siva a-siva mentioned this issue Jan 16, 2020
Closed
@franklinyow franklinyow added this to the D28 Release milestone Jan 21, 2020
dart-bot pushed a commit that referenced this issue Jan 22, 2020
@rmacnak-google
[test] Remove dart2js tests of MirrorsUsed. Remove MirrorsUsed annota…
7295841 
…tions for all tests.

Remove tests using both dart:mirrors and dart:html.

Bug: #40045
Change-Id: Ib0fcaab497fee6c18460199ae2db18451408b015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132740
Reviewed-by: Ben Konyi <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 22, 2020
@rmacnak-google
[test] Changes to mirrors tests to make them more Dart 3 compatible.
439caba 
These changes are not sufficient by themselves, but the subset that can still run in Dart 2.

Bug: #40045
Change-Id: Ie8f61fc9ee94b85329a701f97b5d3f91dbc1f889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132422
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Siva Annamalai <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
@eernstg
Copy link
Member

eernstg commented Jan 22, 2020

Hi, @rmacnak-google, I considered migrating the tests. How would that fit into your plans?

dart-bot pushed a commit that referenced this issue Jan 22, 2020
@rmacnak-google
[test] Fork mirrors tests.
00b2e58 
Bug: #40045
Change-Id: I597259b38684de87016f1e136723d24f4ac05420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132440
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
dart-bot pushed a commit that referenced this issue Jan 22, 2020
@rmacnak-google
[lib] Be explicit about the type parameter for positional argument li…
b07b710 
…sts.

Widen `reflect` and `setField` to accept dynamic. `Object` will soon no longer be a top type, and dynamic is more consistent with other reflective inputs and `reflectee`.

Bug: #40045
Change-Id: Ic1e3a26aaea5de078cc616846cb52417c7975d11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132720
Reviewed-by: Siva Annamalai <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
@rmacnak-google
Copy link
Contributor

Hi, @eernstg, I already have a CL with the tests migrated.

@eernstg
Copy link
Member

eernstg commented Jan 23, 2020

OK, thanks!

dart-bot pushed a commit that referenced this issue Jan 23, 2020
@rmacnak-google
[test] Update copied mirrors tests for Dart 3.
081e2ac 
Bug: #40045
Change-Id: Ic0f62843d61b613e61f434b72b9553dd1e6897af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132441
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Projects
None yet
Milestone
D28 Release
Development

No branches or pull requests
5 participants
@leafpetersen @rmacnak-google @a-siva @eernstg @franklinyow