Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement toStringAsFixed, toStringAsExponential, toStringAsPrecision for integers #460

Closed
ghost opened this issue Nov 15, 2011 · 8 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@ghost
Copy link

ghost commented Nov 15, 2011

LibTest/core/int/toStringAsExponential/int/toStringAsExponential/A01/t01: Fail
LibTest/core/int/toStringAsFixed/int/toStringAsFixed/A01/t01: Fail
LibTest/core/int/toStringAsPrecision/int/toStringAsPrecision/A01/t01: Fail

@iposva-google
Copy link
Contributor

Added Accepted label.

@vsmenon
Copy link
Member

vsmenon commented Feb 21, 2012

FYI, I hit this in the Dromaeo benchmark. I can work around by converting to double first.

@ghost
Copy link
Author

ghost commented Feb 22, 2012

I have a fix ready shortly (although it may not make sense to call toStringAsFixed on integers, since there is no fraction).

@ghost
Copy link
Author

ghost commented Feb 22, 2012

toStringAsExponential and toStringAsPrecision are not implemented in C++ yet, assigning to floitsch.


Set owner to @floitschG.

@floitschG
Copy link
Contributor

Fixed in r4681.


Added Fixed label.

@floitschG
Copy link
Contributor

Reopening and unassigning me.
I have only implemented the double version in r4681. If the specs allows it, these methods can now be implemented as x.toDouble().toStringAsFixed()...


Removed the owner.
Added Triaged label.

@iposva-google
Copy link
Contributor

Set owner to @sgmitrovic.
Added Accepted label.

@ghost
Copy link
Author

ghost commented Mar 1, 2012

The integers methods have been already implemented as x.toDouble().toStringAsFixed().


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants