Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart editor should show unrecognized types in a different color #491

Closed
DartBot opened this issue Nov 17, 2011 · 4 comments
Closed

dart editor should show unrecognized types in a different color #491

DartBot opened this issue Nov 17, 2011 · 4 comments
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Milestone
M1

Comments

@DartBot
Copy link

DartBot commented Nov 17, 2011

This issue was originally filed by [email protected]

If I misspell a class name, it doesn't seem like Dart Editor shows anything to visually distinguish the misspelled word. But, clearly Dart Editor knows, because I can hover over it with ctrl-mouse, and then see it change to a hyperlink if it is recognized.
I think it would be nice if there was a squiggly under it or the text was in a different color.
@bwilkerson
Copy link
Member

I'm guessing that if you were to save the file with the misspelled class name we would then generate an error for it and it would get a red squiggly to mark it. (If not, then it's a compiler bug.)

I think this issue woud best be resolved by adding the more general feature of compile-as-you-type, which is something we definitely want to add.

Removed Type-Defect label.
Added Type-Enhancement, Usability, Accepted labels.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Added this to the Later milestone.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Added Duplicate label.
Marked as being merged into #2465.

@clayberg
Copy link

Removed this from the Later milestone.
Added this to the M1 milestone.
Marked as being merged into #dart:2465.

@DartBot DartBot added Type-Enhancement closed-duplicate Closed in favor of an existing report labels Sep 18, 2012
@DartBot DartBot added this to the M1 milestone Sep 18, 2012
@danrubel danrubel mentioned this issue Jun 3, 2015
Closed
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue Nov 16, 2022
@devoncarew
Bump markdown to 37951d151750acfae756b2e466f563c1c5119b3d
fcc933a 
Changes:
```
> git log --format="%C(auto) %h %s" a70b93a..37951d1
 https://dart.googlesource.com/markdown.git/+/37951d1 Fix an ImageSyntax issue (#493)
 https://dart.googlesource.com/markdown.git/+/29196b7 Refactor CodeBlockSyntax (#488)
 https://dart.googlesource.com/markdown.git/+/32c52d6 benchmark: use Stopwatch over DateTime for benchmarking (#491)
 https://dart.googlesource.com/markdown.git/+/0a7a531 Refactor ATX headings (#486)
 https://dart.googlesource.com/markdown.git/+/2fab846 some cleanup (#489)
 https://dart.googlesource.com/markdown.git/+/816dd87 Refactor CodeSyntax (#487)
 https://dart.googlesource.com/markdown.git/+/a529e58 Fix HTML escape issues (#484)

```

Diff: https://dart.googlesource.com/markdown.git/+/a70b93a1a004cc1da04a3e3ea59821ef8391e0d6~..37951d151750acfae756b2e466f563c1c5119b3d/
Change-Id: I3f8419477df2280801be3cf9251e003f6c482984
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270224
Commit-Queue: Samuel Rawlins <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
M1
Development

No branches or pull requests
5 participants
@kevmoo @danrubel @bwilkerson @clayberg @DartBot