Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patterns] Syntax highlighters implementation #49752

Closed
2 of 3 tasks
itsjustkevin opened this issue Aug 19, 2022 · 6 comments
Closed
2 of 3 tasks

[Patterns] Syntax highlighters implementation #49752

itsjustkevin opened this issue Aug 19, 2022 · 6 comments
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Milestone

Comments

@a-siva a-siva added the area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). label Aug 19, 2022
@itsjustkevin itsjustkevin added this to the Dart 3 beta 3 milestone Feb 6, 2023
@srawlins
Copy link
Member

srawlins commented Mar 2, 2023

A note for tracking: These features are completed "out-of-band": they do not require changes to the Dart SDK or the Flutter repositories, so they can be landed after the Beta 3 deadline. I think it is still good to track them with the Beta 3 milestone for now.

@itsjustkevin
Copy link
Contributor Author

Agree that this should be done before stable. From my perspective, this is still part of the minimum viable product. I would like to continue tracking this in beta 3, but will take a look again after we have filtered down the items in beta 3.

@vsmenon
Copy link
Member

vsmenon commented Apr 18, 2023

@domesticmouse - per checklist above - is there any work here you were planning on? And anything blocking?

@domesticmouse
Copy link
Member

@domesticmouse - per checklist above - is there any work here you were planning on? And anything blocking?

I believe CodeMirror is in a good place. I added the new keywords in codemirror/codemirror5@6a70589 and codemirror/codemirror5@c17c5f0

@vsmenon
Copy link
Member

vsmenon commented Apr 24, 2023

Thanks - can we close this?

@vsmenon
Copy link
Member

vsmenon commented Apr 25, 2023

I'll close.

@vsmenon vsmenon closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Projects
None yet
Development

No branches or pull requests

5 participants