-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sealed class] Syntax highlighters implementation #51283
Comments
@itsjustkevin - it would be useful for this issue to list out the various systems to update (or verify that they work as is) |
I added the list we've been using for the last two years. |
A note for tracking: These features are completed "out-of-band": they do not require changes to the Dart SDK or the Flutter repositories, so they can be landed after the Beta 3 deadline. I think it is still good to track them with the Beta 3 milestone for now. |
See #49752 |
The textmate grammar changes were done in dart-lang/dart-syntax-highlight#38 |
Any updates here? |
@domesticmouse - per checklist above - is there any work here you were planning on? And anything blocking? |
ping @domesticmouse @itsjustkevin - do we have anything left here? I don't think this would block a release. Should we move to cleanup? |
@domesticmouse - closing based on your comment in the other issue. |
@vsmenon added https://github.com/codemirror/codemirror5 commits that add keywords |
Cobbling together the list from past issues:
base
,interface
,sealed
, andwhen
keywords highlightjs/highlight.js#3726The text was updated successfully, but these errors were encountered: