Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sealed class] Syntax highlighters implementation #51283

Closed
3 tasks done
Tracked by #51278
itsjustkevin opened this issue Feb 6, 2023 · 10 comments
Closed
3 tasks done
Tracked by #51278

[Sealed class] Syntax highlighters implementation #51283

itsjustkevin opened this issue Feb 6, 2023 · 10 comments
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Milestone

Comments

@itsjustkevin itsjustkevin added this to the Dart 3 beta 3 milestone Feb 6, 2023
@devoncarew devoncarew added the area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). label Feb 7, 2023
@devoncarew
Copy link
Member

devoncarew commented Feb 7, 2023

@itsjustkevin - it would be useful for this issue to list out the various systems to update (or verify that they work as is)

@srawlins
Copy link
Member

srawlins commented Mar 2, 2023

I added the list we've been using for the last two years.

@srawlins
Copy link
Member

srawlins commented Mar 2, 2023

A note for tracking: These features are completed "out-of-band": they do not require changes to the Dart SDK or the Flutter repositories, so they can be landed after the Beta 3 deadline. I think it is still good to track them with the Beta 3 milestone for now.

@itsjustkevin
Copy link
Contributor Author

See #49752

@DanTup
Copy link
Collaborator

DanTup commented Mar 2, 2023

The textmate grammar changes were done in dart-lang/dart-syntax-highlight#38

@leafpetersen
Copy link
Member

Any updates here?

@vsmenon
Copy link
Member

vsmenon commented Apr 18, 2023

@domesticmouse - per checklist above - is there any work here you were planning on? And anything blocking?

@vsmenon
Copy link
Member

vsmenon commented Apr 24, 2023

ping

@domesticmouse @itsjustkevin - do we have anything left here? I don't think this would block a release. Should we move to cleanup?

@vsmenon
Copy link
Member

vsmenon commented Apr 25, 2023

@domesticmouse - closing based on your comment in the other issue.

@vsmenon vsmenon closed this as completed Apr 25, 2023
@domesticmouse
Copy link
Member

@vsmenon added https://github.com/codemirror/codemirror5 commits that add keywords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas).
Projects
None yet
Development

No branches or pull requests

7 participants