[CP] Please cherry-pick cc80ccfaa0b66a89a04cd07081d9f42bcf3d2bcf to stable #50415
Assignees
Labels
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
cherry-pick-approved
Label for approved cherrypick request
merge-to-stable
Comments
annagrin
added
the
cherry-pick-review
|
@annagrin to solve for creating two cherry-pick issues, we can add the second commit hash to this issue in the |
|
@a-siva @vsmenon @johnniwinther @athomas @devoncarew @sigmundch could you all take a look at this cherry-pick request? |
|
lgtm - thanks for the fix, Anna! |
annagrin
changed the title
|
lgtm |
a-siva
added
the
area-web
|
lgtm |
1 similar comment
|
lgtm |
|
Approving. |
itsjustkevin
added
cherry-pick-approved
copybara-service bot
pushed a commit
that referenced
this issue
Nov 11, 2022
Generate calls to super class methods from mixin application stubs using `super` instead of `this`. Bug: #50119 Change-Id: I02802ea828d72d9221f1886195acb91e6c9520ac Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/267822 Fixed:#50415 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268604 Reviewed-by: Sigmund Cherem <[email protected]> Reviewed-by: Joshua Litt <[email protected]>
|
This fix was landed on stable as https://dart.googlesource.com/sdk/+/657d2c945c6e5518ace546ff70803155e9b45f31 and was released in stable 2.18.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
cc80ccf
Target
beta, stable
Prepared changelist for beta/stable
https://dart-review.git.corp.google.com/c/sdk/+/268604
Issue Description
Issue
Defining a mixin application in a separate library from the mixin declaration with a private field caused stack overflow during execution.
Platforms
web
What is the fix
The issue was caused by and optimization using
thisto implement calls tosuperfor non-overriden private accessors.The fix is to disable the optimization inside the bodies of mixin application accessor stubs.
Why cherry-pick
The issue has caused crashes for users of
package:riverpod/riverpod.dart:Original issue: rrousselGit/riverpod#1713
Risk
low
Issue link(s)
#50119
Extra Info
No response
The text was updated successfully, but these errors were encountered: