Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] DevTools 2.28.5 #54427

Closed
kenzieschmoll opened this issue Dec 20, 2023 · 1 comment
Closed

[CP] DevTools 2.28.5 #54427

kenzieschmoll opened this issue Dec 20, 2023 · 1 comment
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@kenzieschmoll
Copy link
Contributor

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/343001

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/343001

Issue Description

Fixes bugs preventing DevTools extension for loading on Windows and for Dart app connections that are spawned through DDS. This also adds a fix for pointing stable users to the proper location of the devtools survey metadata file.

What is the fix

Release a cherry-pick release of DevTools into the Dart / Flutter SDKs that includes the linked 7 commits: flutter/devtools#6995

Why cherry-pick

This is blocking users on stable. For issues and reasons why we selected each commit, see above.

Risk

low

Issue link(s)

flutter/devtools#6995

Extra Info

No response
@kenzieschmoll kenzieschmoll added the cherry-pick-review Issue that need cherry pick triage to approve label Dec 20, 2023
@mit-mit
Copy link
Member

mit-mit commented Dec 21, 2023

SGTM

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Dec 21, 2023
copybara-service bot pushed a commit that referenced this issue Dec 21, 2023
@kenzieschmoll @athomas
[stable] Cherry-pick DevTools 2.28.5
3eb3c8f 
Bug: #54427
Change-Id: I9aca36cca537e59264911a1f59faf3dbe8ade844
Cherry-pick: flutter/devtools@v2.28.4...2.28.5
Cherry-pick-request: #54427
Fixes: #54427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343300
Reviewed-by: Kevin Chisholm <[email protected]>
@lrhn lrhn added the area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). label Dec 25, 2023
@lrhn lrhn closed this as completed Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@vsmenon @lrhn @whesse @itsjustkevin @mit-mit @athomas @kenzieschmoll