[CP] Fix Dart2js stack overflow in value range analysis

[biggs0125]

Commit(s) to merge

6a9b550

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/344241

Issue Description

Dart2JS is crashing with a stack overflow in some scenarios when a variable is declared before a loop and updated within the loop. This logic was improved recently but some logic was missed when dispatching operators within the value range analyzer.

What is the fix

The fix is to correctly delegate operations within Dart2JS's value range analysis.

Why cherry-pick

This can cause the compiler to crash on fairly trivial code. For example (from original bug):

void main() {
  int counter = 0;
  for (int i = 0; i < 5; i++) {
      counter += counter;
  }
}

Risk

low

Issue link(s)

#54453

Extra Info

No response

[sigmundch]

I'm very much in favor of cherry-picking. This regression was introduced in 3.2 and causes the compiler to crash. The fix is small and low-risk.

[itsjustkevin]

Cherry-pick approved feel free to merge @biggs0125.

[parlough]

Fix landed in 719a36e which was part of today's release of Dart 3.2.5 :)

Thanks all!