[CP] Migrate from Goma to RBE #55184
Assignees
Labels
area-infrastructure
Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-merged
Cherry-pick has been merged to the stable or beta branch.
cherry-pick-review
Issue that need cherry pick triage to approve
merge-to-beta
merge-to-stable
triage-automation
See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.
Comments
sortie
added
the
cherry-pick-review
|
@athomas @whesse and @godofredoc can you take a look at this cherry-pick? |
|
dart-github-bot
added
area-build
devoncarew
added
area-infrastructure
|
CP LGTM |
itsjustkevin
added
cherry-pick-approved
|
Oh I didn't get a notification when @itsjustkevin added the cherry-pick-approved label. It's always unclear when a CP is actually approved, what the criteria is. It would be nice if you explicitly comment that the changes can land. I'll land these now. |
copybara-service bot
pushed a commit
that referenced
this issue
Mar 19, 2024
This change is a necessary infrastructure migration that switches building dart for testing to RBE instead of Goma. The release artifacts are unchanged as RBE must not be used for official releases and only affects the commit queue and post-submit testing. The anthology of RBE commits to main since the 3.3.0 branch point is cherry-picked in their entirety without merge conflicts to put the stable branch in the same supported state as main. Bug: b/296994239 Change-Id: I45d13ccc5aba49313e52a3f7bac0be4628608881 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355761 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355780 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355683 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355400 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/343440 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/354240 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/345543 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/345542 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/345540 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/345520 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/345286 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/342360 Cherry-pick-request: #55184 Changelog-Exempt: Infrastructure change invisible to end users Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357324 Reviewed-by: William Hesse <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Mar 19, 2024
This change is a necessary infrastructure migration that switches building dart for testing to RBE instead of Goma. The release artifacts are unchanged as RBE must not be used for official releases and only affects the commit queue and post-submit testing. The anthology of RBE commits to main since the 3.4.0-190.1 branch point is cherry-picked in their entirety without merge conflicts to put the beta branch in the same supported state as main. Bug: b/296994239 Change-Id: I0b454d9d95e7bb6f978db344ba9eadfde6e979dc Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355761 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355780 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355683 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/355400 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/343440 Cherry-pick-request: #55184 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357342 Reviewed-by: William Hesse <[email protected]>
itsjustkevin
added
the
cherry-pick-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
12 commits for stable, 5 commits for beta
Target
stable and beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/357324 for stable and https://dart-review.googlesource.com/c/sdk/+/357342 for beta
Issue Description
Dart must switch from Goma to RBE before the shutdown of Goma in the near future. We've already migrated the main channel successfully. However, the beta and stable channels continue to use Goma as the RBE support has not landed on them. Based on our release schedule, the necessary RBE support is not scheduled to land on beta/stable in time for the Goma shutdown. Therefore we need to cherry-pick the needed support to the release channels.
What is the fix
The full set of RBE commits on the main channel since the respective channels needs to be cherry-picked in their entirety. This solution ensures the RBE setup is identical between main (as it is right now) and the release channels, which puts them into a fully supported state.
The release artifacts are unchanged. RBE/Goma must not and is not used for release artifacts. This change affects testing only.
Why cherry-pick
We become unable to run the commit queue and post-submit testing on beta and stable when Goma is shut down. Additionally our new RBE partner team is asking us to turn down our old traffic to ensure we have completed the migration.
Risk
low
The exact same code is tested continuously on the main branch. Only testing is affected, RBE/Goma is not used for the release artifacts, which are unchanged.
The commit queue will test all aspects of this change since it affects testing only.
Issue link(s)
b/296994239
Extra Info
No release needs to be made with these cherry-picks as they are infrastructure only and are invisible to end users. They need to be committed such that other cherry-picks affecting customers can be released.
The text was updated successfully, but these errors were encountered: