Cherry pick "Shut down pub http client after running dartdev" #55402
Assignees
Labels
area-dart-cli
Use area-dart-cli for issues related to the 'dart' command like tool.
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
Comments
sigurdm
added
the
cherry-pick-review
|
sgtm |
lrhn
added
the
area-dart-cli
|
I added the follow-up https://dart-review.googlesource.com/c/sdk/+/362360 to the picked CL's They are both included in the prepared CL. |
itsjustkevin
added
the
cherry-pick-approved
|
Tagging @athomas for info |
copybara-service bot
pushed a commit
that referenced
this issue
Apr 15, 2024
Bug: #55289 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/361364 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/362360 Cherry-pick-request: #55402 Change-Id: I61548d0b223167b769a27ac6ab956c4fd42a7be6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/361562 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
https://dart-review.googlesource.com/c/sdk/+/361364
https://dart-review.googlesource.com/c/sdk/+/362360
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/361562
Issue Description
When
dart runtriggers apub getthe httpclient is not shut down, leaving the process hanging for ~15 seconds.What is the fix
Shut down the client.
Later we plan to manage the http client in a more structured manner, but this fix seems harmless and sufficient for now.
Why cherry-pick
To avoid the issue - leading to a frustrating user experience.
Risk
medium-low.
Issue link(s)
#55289
Extra Info
No response
The text was updated successfully, but these errors were encountered: