[CP] [dart2wasm] Only share type parameter fields if nullability allows #55895
Assignees
Labels
cherry-pick-approved
Label for approved cherrypick request
cherry-pick-review
Issue that need cherry pick triage to approve
Comments
mkustermann
added
the
cherry-pick-review
|
Limited impact, has coverage, LGTM |
|
This CP was merged. |
copybara-service bot
pushed a commit
that referenced
this issue
Jun 3, 2024
…allows Bug: #55741 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/366940 Cherry-pick-request: #55895 Change-Id: I69b31dfff0eddd437becae79a5ae49683906088d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369241 Reviewed-by: Ömer Ağacan <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit(s) to merge
e6e9b4e
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/369241
Issue Description
A bug in the dart2wasm compiler can lead to a type parameter type to have incorrect nullability
What is the fix
Fix sharing of type parameter values with super types if nullability is changed.
Why cherry-pick
External user hit this (#55741)
Risk
Low
Issue link(s)
#55741
Extra Info
No response
The text was updated successfully, but these errors were encountered: