Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path library should include the server name in UNC roots #7323

Closed
nex3 opened this issue Dec 11, 2012 · 5 comments
Closed

path library should include the server name in UNC roots #7323

nex3 opened this issue Dec 11, 2012 · 5 comments
Assignees
@nex3
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@nex3
Copy link
Member

nex3 commented Dec 11, 2012

Currently the path library considers a Windows path such as "\foo\bar" to have its root as "". It should instead consider the root to be "\foo", as "foo" in this case is not a directory but the name of the server being connected to.
@munificent
Copy link
Member

Set owner to @munificent.
Removed Area-Pub label.
Added Area-Pkg, Package-Path labels.

@nex3
Copy link
Member Author

nex3 commented Nov 9, 2013

Added Library-Path label.

@nex3
Copy link
Member Author

nex3 commented Nov 9, 2013

Removed Package-Path label.

@nex3
Copy link
Member Author

nex3 commented Nov 13, 2013

Set owner to @nex3.
Added Started label.

@nex3
Copy link
Member Author

nex3 commented Nov 14, 2013

Fixed in r30257.

Added Fixed label.

@nex3 nex3 added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Nov 14, 2013
@nex3 nex3 self-assigned this Nov 14, 2013
natebosch added a commit to dart-archive/path that referenced this issue Apr 6, 2020
@natebosch
Add a UNC example to rootPrefix docs
5bf373e 
Resolves an old TODO. The related issue is closed:
dart-lang/sdk#7323

The change that closed the issues is
https://codereview.chromium.org//59133009

Add an example based on one of the tests.

Also switch another example from `dartlang.org` to `dart.dev`.
natebosch added a commit to dart-archive/path that referenced this issue Apr 6, 2020
@natebosch
Add a UNC examples to rootPrefix and split docs
ce95953 
Resolves some old TODOs. The related issue is closed:
dart-lang/sdk#7323

The change that closed the issues is
https://codereview.chromium.org/59133009

Add examples based on the tests added in that change.

Remove another TODO referencing the issue which I think is resolved.
@natebosch natebosch mentioned this issue Apr 6, 2020
Merged
natebosch added a commit to dart-archive/path that referenced this issue Apr 7, 2020
@natebosch
Add a UNC examples to rootPrefix and split docs (#73)
2d245ec 
Resolves some old TODOs. The related issue is closed:
dart-lang/sdk#7323

The change that closed the issues is
https://codereview.chromium.org/59133009

Add examples based on the tests added in that change.

Remove another TODO referencing the issue which I think is resolved.
mosuem pushed a commit to dart-lang/core that referenced this issue Oct 16, 2024
@natebosch
Add a UNC examples to rootPrefix and split docs (dart-archive/path#73)
5c479bd 
Resolves some old TODOs. The related issue is closed:
dart-lang/sdk#7323

The change that closed the issues is
https://codereview.chromium.org/59133009

Add examples based on the tests added in that change.

Remove another TODO referencing the issue which I think is resolved.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @munificent