-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912
Comments
Lets hope that dart:html will be able to export dart:dom's XmlHttpRequest simply by typedef. |
This isn't a class that can be exported by typedef as we want to use XMLHttpRequest.on.load instead of XMLHttpRequest.addEventListener |
Issue #3133 has been merged into this issue. |
Removed Priority-Medium label. |
Set owner to @efortuna. |
XMLHttpRequest is a mainstay name for web developers. I don't support changing the name unless we significantly enhance the interface, make is Darty, and unify it with dart:io's HttpRequest. If we do so, we must heavily document that XMLHttpRequest is now HttpRequest (so the inevitable searches will still work) See also issue #2677 |
@seth: yeah, we're going to do that--make it Darty and unify with dart:io :). We need to get dart:html types to be as nice as jQuery APIs (e.g. jQuery.ajax) Totally agree on needing some way to help people find the new names. I find this issue with lots of the DOM apis. one idea is to "typedef" the old names and make them @deprecated pointing at the new names. Basically some other way to tell the editor to help users when they try to use "XMLHttpRequest", "HTMLElement", or "appendChild" etc ... |
This is a good opportunity to document HttpRequest. When we change the name, the MDN docs will be even less relevant. |
This comment was originally written by [email protected] Would ResourceRequest name be a better fit? |
This was committed in r11070. Added Fixed label. |
2020-10-12 [email protected] #951. Changed error expectation to not to fail on tryjobs 2020-10-12 [email protected] #912. Added tests for external variable declaration Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I8e27b4a1605a9503056c3d18e0a8cd4b2d7b3383 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166848 Commit-Queue: Alexander Thomas <[email protected]> Auto-Submit: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
2020-11-05 [email protected] Fixes #602: New tests for least and greatest closures added. 2020-11-05 [email protected] #926. Rewrite io/Process/start_A01_t02 test to work on precompiled environment 2020-11-05 [email protected] #932. Rewrite HttpRequestUpload/onLoad_A01_t01 test to send correct HttpRequest 2020-11-04 [email protected] Fixes #956. Don't expect extension invocation on type dynamic 2020-11-04 [email protected] Convert some multi-tests to static error framework (#958) 2020-11-03 [email protected] Fixes #602: dynamic tests for least and greatest closures updated. 2020-11-03 [email protected] Fixes #602: tests for least and greatest closures added. 2020-10-28 [email protected] #926. Fix two Process tests to use 'process_test' tool 2020-10-28 [email protected] #926. Rewrite two Process tests to use 'process_test' tool 2020-10-28 [email protected] Fixes #955. Expect less specific error for typed_data tests 2020-10-26 [email protected] Fixes #954. Change the line where we expect an error for CFE 2020-10-20 [email protected] Fixes #912. Abstract variables syntax tests added 2020-10-19 [email protected] #912. More external variables syntax tests added 2020-10-17 [email protected] External variables syntax test added 2020-10-16 [email protected] #912. More test for static analysis of external variables added 2020-10-15 [email protected] #912. Test for static analysis of external variables added 2020-10-14 [email protected] #912. Test for static analysis if abstract variables added Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: Id9cde784918faa4e891da8c4cb448d415a7a18aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170680 Reviewed-by: William Hesse <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
The current name is needlessly verbose, inconsistent, and doesn't match the style guide.
The text was updated successfully, but these errors were encountered: