Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG elements does not show #997

Closed
DartBot opened this issue Dec 29, 2011 · 8 comments
Closed

SVG elements does not show #997

DartBot opened this issue Dec 29, 2011 · 8 comments
Assignees
@nex3
Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable

Comments

@DartBot
Copy link

DartBot commented Dec 29, 2011

This issue was originally filed by @ltackmann

What steps will reproduce the problem?

  1. Create a SVG element in the HTML file
  2. use document.query to access it
  3. update the SVG element from Dart (fx. set attributes)

What is the expected output? What do you see instead?

The attributes should be updated and the SVG picture should show

What version of the product are you using? On what operating system?

Tested with MaxOSX using frogc build 2817 and DartEditor build 2804

Please provide any additional information below.

I have made a complete (short) test case here in this gist https://gist.github.com/1531821
@DartBot
Copy link
Author

DartBot commented Dec 29, 2011

This comment was originally written by @ltackmann

Just to clarify the result. The SVG markup is correctly updated/created by Dart but nothing shows (i.e. you cannot see the SVG drawing). If the SVG markup is copied to another site then it works correctly.

@rakudrama
Copy link
Member

Added Area-UI, Triaged labels.

@dgrove
Copy link
Contributor

dgrove commented Jan 2, 2012

Set owner to @jacob314.

@jacob314
Copy link
Member

jacob314 commented Jan 4, 2012

Set owner to @nex3.

@nex3
Copy link
Member

nex3 commented Jan 4, 2012

Just to clarify... are you creating the SVG element from within Dart, or is it already in the HTML file? Can you give me an example of Dart code for manipulating the SVG that isn't working how you expect?

@DartBot
Copy link
Author

DartBot commented Jan 4, 2012

This comment was originally written by @ltackmann

I am creating the SVG code in Dart using the Element.html construct. Sample is here https://gist.github.com/1531821

@nex3
Copy link
Member

nex3 commented Jan 4, 2012

Ah, that's your problem. You need to use SVGElement.tag when dealing with SVG elements, since SVG requires a different namespace than normal HTML elements.

At some point we'll have more documentation and examples of working with SVG that should make this clearer.

Added Invalid label.

@DartBot
Copy link
Author

DartBot commented Jan 4, 2012

This comment was originally written by @ltackmann

Works like a charm updated sample here https://gist.github.com/1531821

@DartBot DartBot added Type-Defect closed-invalid Closed as we don't believe the reported issue is generally actionable labels Jan 4, 2012
dart-bot pushed a commit that referenced this issue Mar 17, 2021
@athomas
[co19] Roll co19 to 8cf837f5abf0a30ed91ebf480df58e5c0480947e
5a81552 
2021-03-17 [email protected] Fixes #1017. Use => for setter returning value tests
2021-03-16 [email protected] Issue #996: more tests for Generic functions as type arguments and bounds added.
2021-03-16 [email protected] Fixes #1005. Description updated for method_definition tests
2021-03-16 [email protected] Fixes #1011. Expect an error if non-function type is called as a function
2021-03-16 [email protected] Issue #996: tests for Generic functions as type arguments and bounds re-factored, more tests added.
2021-03-15 [email protected] Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 [email protected] Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 [email protected] Missed experiment flag added
2021-03-12 [email protected] Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-12 [email protected] #993. Added tests checking that Struct fields cannot have initializers
2021-03-12 [email protected] #993. Tests for not external members of Struct subtype added
2021-03-11 [email protected] #993. Use package ffi in co19 ffi tests
2021-03-09 [email protected] Fixes #995. Annotations with type arguments tests added
2021-03-09 [email protected] Issue #997: existing triple-shift tests corrected.
2021-03-09 [email protected] More fixes for #535: split constant evaluation tests because static behavior of the strong and weak mode is different.
2021-03-04 [email protected] #993. Array tests added
2021-03-04 [email protected] #993. Pointer equality tests added
2021-03-03 [email protected] #993. Pointer.elementAt() tests added
2021-03-02 [email protected] #993. Pointer.cast() tests added
2021-03-01 [email protected] #993. Pointer tests added
2021-03-01 [email protected] Fixes #936. Change expected result according to the new left top rule
2021-02-26 [email protected] Fixed #998: tests checks output streams correctly now.
2021-02-26 [email protected] #993. IntPtr tests added
2021-02-26 [email protected] #993. More Struct tests added
2021-02-25 [email protected] Tests updated, missing issue tags added.
2021-02-25 [email protected] #1003. Isolate test fixed to not to be a racy
2021-02-25 [email protected] Issue numbers added
2021-02-24 [email protected] Issue number added
2021-02-24 [email protected] #988. Typo in error message fixed
2021-02-24 [email protected] #988. Fix test expectations

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I718644028b1d2a9fbba0c7efdf2923bb67184fde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191409
Reviewed-by: William Hesse <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
closed-invalid Closed as we don't believe the reported issue is generally actionable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nex3 @jacob314 @dgrove @rakudrama @DartBot