Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove annotations no longer needed #91

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Remove annotations no longer needed #91

merged 3 commits into from
Apr 11, 2023

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Apr 10, 2023 •
edited
Loading

It looks like the JS@ annotations on members that aren't renamed are no longer needed, so removing them

@mit-mit mit-mit requested a review from srujzs April 10, 2023 11:06
@srujzs
Copy link

srujzs commented Apr 10, 2023

Yeah, we weren't handling inline class members correctly in our checks, and that's been resolved, so this LGTM!

@mit-mit
Copy link
Member Author

mit-mit commented Apr 10, 2023

Thanks! I'll merge when the build goes green (it needs a new dev channel build published)

@mit-mit mit-mit merged commit 08de7e0 into main Apr 11, 2023
@mit-mit mit-mit deleted the annotations branch April 11, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mit-mit @srujzs