Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test homepage DartPad code #2578

Closed
kwalrath opened this issue Aug 14, 2020 · 2 comments · Fixed by #5552
Closed

Test homepage DartPad code #2578

kwalrath opened this issue Aug 14, 2020 · 2 comments · Fixed by #5552
Assignees
@parlough
Labels
dev.null-safety Relates to transforming or migrating Dart code to sound null safety e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged test.general Relates to unit, integration, perf testing

Comments

@kwalrath
Copy link
Contributor

The upgrade to jekyll (#2570) caused a problem that is making us stop using code-excerpt in the homepage. This means that the code displayed in the embedded DartPad won't be auto-included/tested. Once #2570 and #2575 are in, we should reimplement #2124 in a way that works with the new jekyll.

/cc @johnpryan @theacodes
@kwalrath kwalrath added st.blocked Issue cannot continue until another action completes e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work dev.null-safety Relates to transforming or migrating Dart code to sound null safety p2-medium Necessary but not urgent concern. Resolve when possible. infra.structure Relates to the tools that create dart.dev test.general Relates to unit, integration, perf testing labels Aug 14, 2020
@kwalrath kwalrath added this to the Null safety: stable release milestone Aug 14, 2020
@kwalrath kwalrath removed the st.blocked Issue cannot continue until another action completes label Aug 14, 2020
@parlough parlough removed this from the Null safety: stable release milestone Jul 19, 2021
@parlough parlough mentioned this issue Aug 10, 2021
Closed
This was referenced Sep 16, 2021
Open
Open
@atsansone
Copy link
Contributor

@parlough : Is this still a concern?

@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Apr 11, 2023
@parlough parlough self-assigned this Apr 12, 2023
@parlough
Copy link
Member

Yes this is still a concern.

@parlough parlough mentioned this issue Feb 15, 2024
Merged
parlough added a commit that referenced this issue Feb 15, 2024
@parlough
Finalize cleanup of features relying on old DartPad (#5552)
7a4480d 
- Introduces how to use the exercises on the async await and iterables
codelab pages
- Updates some mentions of already removed DartPad features (old
channel, HTML, etc)
- Replaces "Try Dart" embedded DartPad that's on homepage with simple
embed
- For now, it can rely on the samples present in the DartPad UI, which
we plan to add to
  - Can revisit custom examples in the future.
- A bit of a loss, but the current ones don't show Dart's newest, most
powerful futures anyway
  
Closes #5382
Closes #2578
atsansone pushed a commit to atsansone/site-www that referenced this issue Mar 22, 2024
@parlough @atsansone
Finalize cleanup of features relying on old DartPad (dart-lang#5552)
761224b 
- Introduces how to use the exercises on the async await and iterables
codelab pages
- Updates some mentions of already removed DartPad features (old
channel, HTML, etc)
- Replaces "Try Dart" embedded DartPad that's on homepage with simple
embed
- For now, it can rely on the samples present in the DartPad UI, which
we plan to add to
  - Can revisit custom examples in the future.
- A bit of a loss, but the current ones don't show Dart's newest, most
powerful futures anyway
  
Closes dart-lang#5382
Closes dart-lang#2578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
dev.null-safety Relates to transforming or migrating Dart code to sound null safety e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work infra.structure Relates to the tools that create dart.dev p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged test.general Relates to unit, integration, perf testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finalize cleanup of features relying on old DartPad dart-lang/site-www
3 participants
@atsansone @kwalrath @parlough