Fixed backslash removing from code exceprts #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backslash is not a special character in HTML, so CGI.escapeHTML kept it intact and passed into the frame_code function. At the same time backslash is a special character for sub, so it must be escaped before using as a replacement string. The error effect now is present in the code here https://dart.dev/codelabs/dart-cheatsheet#factory-constructors print('I don\'t recognize $typeName'); became print('I donescaped_code#39;t recognize $typeName');
googlebot
added
the
cla: yes
|
Wow, nice catch and fix! I'm going to ask one of our DPEs to review this. |
|
This looks good to me. I should have put this file in site-shared, since this was taken from the flutter website |
johnpryan
approved these changes
Aug 24, 2020
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backslash is not a special character in HTML, so
CGI.escapeHTMLkept it intact and passed into the frame_code function.At the same time backslash is a special character for
sub, so it must be escaped before using as a replacement string.The error effect now is present in the code here https://dart.dev/codelabs/dart-cheatsheet#factory-constructors
print('I don\'t recognize $typeName');became
print('I donescaped_code#39;t recognize $typeName');