Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support textless spans #3

Open
nex3 opened this issue Apr 29, 2015 · 3 comments
Open

Support textless spans #3

nex3 opened this issue Apr 29, 2015 · 3 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Apr 29, 2015

Currently SourceSpans are required to have text associated with them. However, this isn't always possible; for example, spans extracted from source maps won't necessarily have the text of the source or target available, nor should they need to. We should make text optional and make union() resilient to this.
@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Apr 29, 2015
@nex3 nex3 mentioned this issue Apr 29, 2015
Open
@thosakwe
Copy link

thosakwe commented Jul 5, 2017

Would a PR for this be accepted?

@nex3
Copy link
Member Author

nex3 commented Jul 5, 2017

Sure!

@thosakwe
Copy link

thosakwe commented Jul 5, 2017

Awesome. I'll try to send one ASAP. Thanks for the fast response!

nex3 added a commit to nex3/source_span that referenced this issue Jul 2, 2024
@nex3
Fix the expectChar() error text. (dart-lang#3)
50d0424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @thosakwe