remove uses of runtimeType

[devoncarew]

• remove uses of runtimeType from the codebase (these were all in toString methods; the uses there were changed to just report the main parent type)
• fix Consider not using runtimeType #85

[kevmoo]

Would this mess up the specificity of subclasses?

[devoncarew]

Would this mess up the specificity of subclasses?

Yes, it would change that. Instead of specifying the exact type of the class (FileSpan, SourceSpanWithContext, ...) it would just report the general type (SourceSpan or SourceLocation). We could customize the various subclass toString() methods to report the more specific subclass type, or introducing some String get typeName abstraction that the general toString() method could call. I'm not sure how much effort or architecture is warranted here however, given that the toString() methods are just used for improved diagnostics when debugging.

It's perhaps worth customizing some of the main subclasses (FileSpan, ...)?

[kevmoo]

I don't think there is a lot of value in ditching runtimeType. This is not likely used in JS code, etc.

What's the worry?

[devoncarew]

@jonasfj - from #85 - what was your use case (I imagine you were seeing the dart2js warning when building a web app)?

[devoncarew]

(dropping this PR)

[jonasfj]

I think this was a warning from dart2js, I don't recall...

…

On Thu, Nov 3, 2022, 19:29 Devon Carew ***@***.***> wrote: (dropping this PR) — Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABERZH4KAEAF6XKXLYOVE3WGQABPANCNFSM6AAAAAAQDSWUN4> . You are receiving this because you were mentioned.Message ID: ***@***.***>