Add retry logic #17
Merged
Add retry logic #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Nov 15, 2019
lib/client/sse_client.dart
Outdated
| if (!(_errorTimer?.isActive ?? false)) { | ||
| // By default the SSE client uses keep-alive. | ||
| // Allow for a retry to connect before giving up. | ||
| _errorTimer = Timer(const Duration(seconds: 5), () { |
There was a problem hiding this comment.
Where did 5 seconds come from?
There was a problem hiding this comment.
Just a number that has worked well in practice for internal systems. Realistically the event source reconnect should be sub second. This gives plenty of overhead.
lib/client/sse_client.dart
Outdated
| /// [serverUrl] is the URL under which the server is listening for | ||
| /// incoming bi-directional SSE connections. | ||
| SseClient(String serverUrl) { | ||
| SseClient(String serverUrl, {bool withRetry}) { |
There was a problem hiding this comment.
synced offline - since all of our known use cases will want to use retry I think we can roll to version 3.0.0 and make it non-optional. This package shouldn't have an overwhelming amount of churn to bump.
natebosch
approved these changes
Nov 15, 2019
|
|
||
| - Add retry logic. | ||
|
|
||
| ** Possible Breaking Change ** Error messages may now be delayed up to 5 seconds |
There was a problem hiding this comment.
Should we say "Error messages for disconnects"?
There was a problem hiding this comment.
General error messages may be delayed as we have no way to make a distinction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I don't have a good way to test the retry logic in a unit test. Open to suggestions. Went ahead and added the option to ensure we didn't regress on current tests.
Note we now close the
eventSourceon error as it continually attempts to reconnect. Somewhat related to dart-lang/webdev#818.