Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the package:vm_service constraint to allow version 14.x #2157

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Update the package:vm_service constraint to allow version 14.x #2157

merged 1 commit into from
Dec 13, 2023
+2 −1

Conversation

derekxu16
Copy link
Member

No description provided.

@derekxu16 derekxu16 mentioned this pull request Dec 13, 2023
Merged
@jakemac53
Copy link
Contributor

It looks like CI is not actually pickup up the latest version here - are we confident it will work?

@derekxu16
Copy link
Member Author

It looks like CI is not actually pickup up the latest version here - are we confident it will work?

Ah, that's because package:coverage needs to have its package:vm_service constraint updated as well. I'm in the process of doing that. I am confident that this will work.

@jakemac53 jakemac53 merged commit 48a2bc3 into dart-lang:master Dec 13, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@natebosch natebosch Awaiting requested review from natebosch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekxu16 @jakemac53