Fix analysis across packages (#1187)

dart-lang · Nov 4, 2024 · b028012 · b028012
1 parent f5d3a19
commit b028012
Show file tree

Hide file tree

Showing 12 changed files with 9 additions and 16 deletions.
diff --git a/.github/workflows/bazel_worker.yaml b/.github/workflows/bazel_worker.yaml
@@ -30,7 +30,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        sdk: [3.1.0, dev]
+        sdk: [3.4, dev]
     steps:
       - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
       - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672

diff --git a/pkgs/bazel_worker/CHANGELOG.md b/pkgs/bazel_worker/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.1.3-wip
+
+* Require Dart SDK `^3.4.0`.
+
 ## 1.1.2
 
 * Require Dart SDK `^3.1.0`.

diff --git a/pkgs/bazel_worker/analysis_options.yaml b/pkgs/bazel_worker/analysis_options.yaml
@@ -7,7 +7,3 @@ analyzer:
   errors:
     # For the generated file
     lines_longer_than_80_chars: ignore
-
-linter:
-  rules:
-    - package_api_docs
diff --git a/pkgs/bazel_worker/e2e_test/pubspec.yaml b/pkgs/bazel_worker/e2e_test/pubspec.yaml
@@ -2,14 +2,14 @@ name: e2e_test
 publish_to: none
 
 environment:
-  sdk: '>=2.19.0 <4.0.0'
+  sdk: ^3.4.0
 
 dependencies:
   bazel_worker:
     path: ../
 
 dev_dependencies:
-  cli_util: ^0.4.0
+  cli_util: ^0.4.2
   dart_flutter_team_lints: ^1.0.0
   path: ^1.8.0
   test: ^1.16.0
diff --git a/pkgs/bazel_worker/e2e_test/test/e2e_test.dart b/pkgs/bazel_worker/e2e_test/test/e2e_test.dart
@@ -11,7 +11,6 @@ import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 
 void main() {
-  var sdkPath = getSdkPath();
   var dart = p.join(sdkPath, 'bin', 'dart');
   runE2eTestForWorker('sync worker',
       () => Process.start(dart, [p.join('bin', 'sync_worker.dart')]));

diff --git a/pkgs/bazel_worker/pubspec.yaml b/pkgs/bazel_worker/pubspec.yaml
@@ -1,11 +1,11 @@
 name: bazel_worker
-version: 1.1.2
+version: 1.1.3-wip
 description: >-
   Protocol and utilities to implement or invoke persistent bazel workers.
 repository: https://github.com/dart-lang/tools/tree/main/pkgs/bazel_worker
 
 environment:
-  sdk: ^3.1.0
+  sdk: ^3.4.0
 
 dependencies:
   async: ^2.5.0

diff --git a/pkgs/boolean_selector/analysis_options.yaml b/pkgs/boolean_selector/analysis_options.yaml
@@ -4,4 +4,3 @@ linter:
   rules:
     - avoid_unused_constructor_parameters
     - cancel_subscriptions
-    - package_api_docs
diff --git a/pkgs/coverage/analysis_options.yaml b/pkgs/coverage/analysis_options.yaml
@@ -14,7 +14,6 @@ linter:
     - cancel_subscriptions
     - comment_references
     - literal_only_boolean_expressions
-    - package_api_docs
     - prefer_final_locals
     - sort_constructors_first
     - sort_unnamed_constructors_first

diff --git a/pkgs/graphs/analysis_options.yaml b/pkgs/graphs/analysis_options.yaml
@@ -24,7 +24,6 @@ linter:
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
-    - package_api_docs
     - prefer_const_declarations
     - prefer_expression_function_bodies
     - prefer_final_locals

diff --git a/pkgs/json_rpc_2/analysis_options.yaml b/pkgs/json_rpc_2/analysis_options.yaml
@@ -10,4 +10,3 @@ linter:
   rules:
     - avoid_unused_constructor_parameters
     - cancel_subscriptions
-    - package_api_docs
diff --git a/pkgs/mime/analysis_options.yaml b/pkgs/mime/analysis_options.yaml
@@ -22,7 +22,6 @@ linter:
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
-    - package_api_docs
     - prefer_const_declarations
     - prefer_expression_function_bodies
     - prefer_final_locals

diff --git a/pkgs/oauth2/analysis_options.yaml b/pkgs/oauth2/analysis_options.yaml
@@ -17,7 +17,6 @@ linter:
     - literal_only_boolean_expressions
     - no_adjacent_strings_in_list
     - no_runtimeType_toString
-    - package_api_docs
     - prefer_const_declarations
     - unnecessary_await_in_return
     - use_string_buffers