[unified_analytics 5.8.8] Prevent FileSystemExceptions from happening when logging outgoing events

[andrewkolos]

The goal of this is to patch unified_analytics v5 with the fixes from #274 and #277.

In summary, unified_analytics logs (the 2500 most-recent) outgoing analytics events. This is primarily to be read in the future for targeted surveys. However, due to some unknown edge case(s) (investigation pending), it's possible this file can reach a massive size. #277 fixed this for unified_analytics v6, but we need to port this to v5, because the stable branch of Flutter (which we want to hotfix) uses v5.

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[andrewkolos]

@devoncarew My intention here is to create a patch for unified_analytics v5 (5.8.8+2). Here's what I've done so far/plan to do:

• 1. Create a branch off of the commit tagged with unified_analytics-v5.8.8+1, cherry-pick fixes from main onto this branch
• 2. Create a unified_analytics-v5.8.8+2 branch and publish it to GitHub.
• 3. File this PR, which merges the branch from 1 into 2.
• 4. Follow the steps from https://github.com/dart-lang/ecosystem/wiki/Publishing-automation#for-committers-publishing-a-release, to get this published to pub.

Let me know if you think this won't work.

[andrewkolos]

It looks like CI only watches the main branch, so I'm not sure what the workflow would be here.

[devoncarew]

This broadly makes sense. A few notes:

• I don't see a tag on this repo for 5.8.8+1 but do see a pub publish for it; we should tag the commit that was published from for posterity
• wrt versioning, we're publishing a new bug fix to 5.8.8; that could just as easily be versioned as 5.8.9 instead of 5.8.8+2 but in practice either version will work
• the publishing automation will want to be publishing from main - it won't handle publishing from a branch. Once this is merged into a new 5.8.x branch - and all the content is ready to go - I can manually publish from that branch. Alternatively I could give you publishing permissions to tools.dart.dev

[jonahwilliams]

LGTM

[andrewkolos]

Oops, I probably should have ran the tests before merging 😛. I'll probably just fix the new branch directly.

[devoncarew]

The tests should have run for this PR automatically.

Looking at the config, it looks like its set up to only run for PRs which target main: https://github.com/dart-lang/tools/blob/main/.github/workflows/unified_analytics.yml; definitely something we should update.