Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dart2js tests on travis #570

Closed
kevmoo opened this issue Jun 29, 2018 · 3 comments
Closed

Fix dart2js tests on travis #570

kevmoo opened this issue Jun 29, 2018 · 3 comments

Comments

@kevmoo
Copy link
Member

kevmoo commented Jun 29, 2018

https://travis-ci.org/dart-lang/typed_data/jobs/398049453

Seems there are a few constants that make dart2js sad...

@munificent
Copy link
Member

I'm probably not the relevant one for this. @jmesserly or @sigmundch, want to take a look? I haven't been closely following the changes around large 64-bit-ish integers.

@sigmundch
Copy link
Member

I'm not familiar with logic on these tests, but they need to be updated to run without using literals that can't be represented in JS, or split so that those large literals are only used in VM tests.

FWIW - all of these large literals are used as parameters for int32x4, which are anyways truncated to 32-bit ints.

chalin referenced this issue in chalin/typed_data Jul 14, 2018
Due to #16. This will get the build green again.
@chalin
Copy link
Contributor

chalin commented Jul 14, 2018

FYI, dart-archive/typed_data#17 splits tests across two Travis jobs, and the browsers tests have been disabled for now. That way we can get the build passing again.

chalin referenced this issue in chalin/typed_data Jul 16, 2018
Due to #16. This will get the build green again.
kevmoo referenced this issue in dart-archive/typed_data Jul 17, 2018
* Skip tests known to be failing

Due to #16. This will get the build green again.
mosuem referenced this issue Oct 16, 2024
* Skip tests known to be failing

Due to dart-lang/typed_data#16. This will get the build green again.
@mosuem mosuem transferred this issue from dart-archive/typed_data Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants