Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish package:web #299

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Publish package:web #299

merged 1 commit into from
Sep 24, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Sep 6, 2024

.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from srujzs September 6, 2024 11:19
Copy link

github-actions bot commented Sep 6, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:web 1.1.0 ready to publish web-v1.1.0

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@srujzs
Copy link
Contributor

srujzs commented Sep 9, 2024

Sorry for the late response! This LGTM, but I'm going to get web updated internally first so that we can be sure 1.1.0 doesn't break google3. I'll approve once that's done and then we can publish.

@kevmoo
Copy link
Member

kevmoo commented Sep 23, 2024

what's our story here, friends? We've made a few changes since this PR went out.

@mosuem mosuem enabled auto-merge (squash) September 23, 2024 18:48
@srujzs
Copy link
Contributor

srujzs commented Sep 23, 2024

It took me a little while for some of the latest changes to roll into Flutter/google3 due to the monorepo, but that's done. A couple PRs opened up in the interim. Most of them have landed, but I'd ideally like to land #291 (just verifying some testing), update g3 (this should be trivial), and then publish sometime tomorrow/Wednesday. If it's really important we publish this ASAP, I can publish another minor release later.

Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package:web is now up-to-date internally. Publishing SGTM!

@kevmoo
Copy link
Member

kevmoo commented Sep 24, 2024

@srujzs – I think it's cool for you to land

@srujzs srujzs merged commit 19cd248 into main Sep 24, 2024
17 checks passed
@srujzs srujzs deleted the publish branch September 24, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants