Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IOWebSocketChannel as a WebSocketAdapterWebSocket subclass #342

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

brianquinlan
Copy link
Contributor

See Simplify the web_socket_channel implementation


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

lib/web_socket_adapter_web_socket_channel.dart Outdated Show resolved Hide resolved
lib/web_socket_adapter_web_socket_channel.dart Outdated Show resolved Hide resolved
@brianquinlan brianquinlan merged commit 429e7d9 into dart-lang:master Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants