Add regression tests against #2446 (#2495)

dart-lang · Sep 26, 2024 · 3ea36fd · 3ea36fd
1 parent 017ab97
commit 3ea36fd
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/dwds/test/instances/common/instance_common.dart b/dwds/test/instances/common/instance_common.dart
@@ -238,6 +238,26 @@ void runTests({
         expect(inspector.isDisplayableObject(ref), isTrue);
       });
 
+      // Regression test for https://github.com/dart-lang/webdev/issues/2446.
+      test(
+        'for a stream',
+        () async {
+          final remoteObject = await inspector.jsEvaluate(
+            libraryVariableExpression('stream', compilationMode),
+          );
+          final ref = await inspector.instanceRefFor(remoteObject);
+          expect(ref!.kind, InstanceKind.kPlainInstance);
+          final classRef = ref.classRef!;
+          expect(classRef.name, '_ControllerStream<int>');
+          expect(
+            classRef.id,
+            'classes|dart:async|_ControllerStream<int>',
+          );
+          expect(inspector.isDisplayableObject(ref), isTrue);
+        },
+        skip: !dartSdkIsAtLeast('3.6.0-148.0.dev'),
+      );
+
       test('for a Dart error', () async {
         final remoteObject = await inspector.jsEvaluate(newDartError);
         final ref = await inspector.instanceRefFor(remoteObject);
@@ -379,6 +399,22 @@ void runTests({
         expect(inspector.isDisplayableObject(instance), isTrue);
       });
 
+      // Regression test for https://github.com/dart-lang/webdev/issues/2446.
+      test(
+        'for a stream',
+        () async {
+          final remote = await inspector.jsEvaluate(
+            libraryVariableExpression('stream', compilationMode),
+          );
+          final instance = await inspector.instanceFor(remote);
+          expect(instance!.kind, InstanceKind.kPlainInstance);
+          final classRef = instance.classRef!;
+          expect(classRef.name, '_ControllerStream<int>');
+          expect(inspector.isDisplayableObject(instance), isTrue);
+        },
+        skip: !dartSdkIsAtLeast('3.6.0-148.0.dev'),
+      );
+
       test('for a Dart error', () async {
         final remoteObject = await inspector.jsEvaluate(newDartError);
         final instance = await inspector.instanceFor(remoteObject);

diff --git a/fixtures/_testSound/example/scopes/main.dart b/fixtures/_testSound/example/scopes/main.dart
@@ -21,6 +21,8 @@ var identityMap = <String, int>{};
 
 var map = <Object, Object>{};
 
+final stream = Stream.value(1);
+
 void staticFunction(int formal) {
   print(formal); // Breakpoint: staticFunction
 }