Skip to content

Commit

Permalink
Merge branch 'main' into misc/dwds-debug-extension-cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
parlough committed Oct 7, 2024
2 parents cf9b7bd + d4b7b83 commit 75712f4
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 6 deletions.
10 changes: 10 additions & 0 deletions dwds/debug_extension/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Dart Debug Extension

The implementation of the [Dart Debug Extension][] for Chrome,
that enables debugging Dart web apps with [Dart DevTools][] by
integrating with [`webdev`][] through [DWDS][].

[Dart Debug Extension]: https://dart.dev/to/web-debug-extension
[Dart DevTools]: https://dart.dev/tools/dart-devtools
[`webdev`]: https://dart.dev/tools/webdev
[DWDS]: https://pub.dev/packages/dwds
1 change: 0 additions & 1 deletion dwds/debug_extension/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: mv3_extension
publish_to: none
version: 2.1.5-wip
homepage: https://github.com/dart-lang/webdev
description: >-
A Chrome extension for Dart debugging.
Expand Down
4 changes: 2 additions & 2 deletions dwds/lib/shared/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Shared directory

The files in this directory are shared between DWDS and external packages (e.g.,
the Dart Debug Extension).
The files in this directory are shared between DWDS and external packages,
such as the [Dart Debug Extension](https://dart.dev/to/web-debug-extension).
2 changes: 1 addition & 1 deletion dwds/web/client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Future<void>? main() {
if (!event.success) {
final alert = 'DevTools failed to open with:\n${event.error}';
if (event.promptExtension && window.confirm(alert)) {
window.open('https://goo.gle/dart-debug-extension', '_blank');
window.open('https://dart.dev/to/web-debug-extension', '_blank');
} else {
window.alert(alert);
}
Expand Down
3 changes: 2 additions & 1 deletion webdev/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ Usage: webdev serve [arguments] [<directory>[:<port>]]...
+ D / Option + D). This also enables
--launch-in-chrome.
--[no-]debug-extension Enable the backend for the Dart Debug
Extension.
Extension. Learn more at
dart.dev/to/web-debug-extension.
--[no-]injected-client Whether or not to inject the
client.js script in web apps. This is
required for all debugging related
Expand Down
3 changes: 2 additions & 1 deletion webdev/lib/src/command/serve_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ refresh: Performs a full page refresh.
help: 'Enable the launching of DevTools (Alt + D / Option + D). '
'This also enables --$launchInChromeFlag.')
..addFlag(debugExtensionFlag,
help: 'Enable the backend for the Dart Debug Extension.')
help: 'Enable the backend for the Dart Debug Extension. '
'Learn more at dart.dev/to/web-debug-extension.')
..addFlag(enableInjectedClientFlag,
help: 'Whether or not to inject the client.js script in web apps. This '
'is required for all debugging related features, but may interact '
Expand Down

0 comments on commit 75712f4

Please sign in to comment.