Don't show non-instantiated variables #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
reviewed
Mar 30, 2023
| @@ -67,6 +67,8 @@ Future<List<Property>> visibleProperties({ | |||
| if (value == null) return true; | |||
|
|
|||
| final type = value.type; | |||
| if (type == 'undefined') return true; | |||
There was a problem hiding this comment.
I think correct behavior according to the vm_service protocol is to have sentinel instead of an InstanceRef, but that would require more work and can be postponed to later.
There was a problem hiding this comment.
Ah nice! We can track in #2056
Added a couple test cases! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2060
Work towards #2056
See screenshots below:
When paused at:
With this change:
nameis not shown (this matches the behavior ofvm_service)countisnull(as expected)firstandsecondare not shown (as expected)Without this change:
nameis shown and isnull(does not matchvm_serviceimplementation!)firstandsecondare shown asnull(not expected!)