Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file dependency. #2185

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Update file dependency. #2185

merged 2 commits into from
Aug 10, 2023

Conversation

bernaferrari
Copy link
Contributor

@bernaferrari
Copy link
Contributor Author

bernaferrari commented Aug 9, 2023 •
edited
Loading

dart_code_metrics is clashing, but that package is deprecated. Should we remove it?

@elliette
Copy link
Contributor

dart_code_metrics is clashing, but that package is deprecated. Should we remove it?

Yes, find to remove dart_code_metrics. Thanks!

elliette
elliette reviewed Aug 10, 2023
View reviewed changes
dwds/analysis_options.yaml Outdated
@@ -23,66 +23,3 @@ linter:
- unawaited_futures
- unnecessary_lambdas

# TODO(https://github.com/dart-lang/webdev/issues/2053): Enable commented-out rules with fixes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh we still want the rules, we just don't need the pub dependency (dart code metrics gets run as a github workflow, and will notify contributor of any changes that are needed on the PR)

Copy link
Contributor Author

@bernaferrari bernaferrari Aug 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if I remove from the pubspec, will it still be run in the workflow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we actually never needed it in the pubspec (we are downloading it in the github workflow). I forgot to remove it from the pubspec a while back 🤦‍♀️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, here it goes again.

elliette
elliette approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elliette elliette merged commit bc00884 into dart-lang:master Aug 10, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
package:dwds run-dcm-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernaferrari @elliette