Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare DWDS for release to version 20.0.1 #2192

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Aug 10, 2023

Resolve version compatibility issues with package:file so that DWDS can be updated in flutter_tools.

See flutter/flutter#123260 (comment)

@@ -15,7 +15,7 @@ dependencies:
collection: ^1.15.0
crypto: ^3.0.2
dds: ^2.7.1
file: ^7.0.0
file: ">=6.0.0 <8.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be conservative, I'd recommend

Suggested change
file: ">=6.0.0 <8.0.0"
file: ">=7.0.0 <8.0.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH wait, actually, this should be >=7.0.0 <9.0.0, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, this is correct as is :)

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit
Copy link

auto-submit bot commented Aug 10, 2023

auto label is removed for dart-lang/webdev/2192, due to - The status or check suite publish / validate has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Maybe prevent submission has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Prevent submission has failed. Please fix the issues identified (or deflake) before re-applying this label.

@elliette elliette merged commit 20cc6d3 into dart-lang:master Aug 10, 2023
80 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants