Fix conflicting webdev smoke package names. #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages rolled into the Dart SDK via DEPS need to have non-colliding package names. Bug: b/297182119
jakemac53
approved these changes
Aug 23, 2023
|
Yeah the thing is that we pin the git repository and the SDK's tools/generate_package_config.dart script automatically adds all the packages it finds to .dart_tools/package_config.json. There is no real mechanism for slicing out the subset of packages that are irrelevant, so this is the easier solution :) |
sortie
deleted the
cl-sortie-fix-conflicting-webdev-sound-package-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages rolled into the Dart SDK via DEPS need to have non-colliding package names.
Bug: b/297182119