Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and contribution for #1620 and #1612 #1627

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 18, 2021

@azeey @costashatz Feel free to update the change log and the contribution descriptions. Thank you for your contributions again!

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #1627 (aca94f8) into main (df90cda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1627   +/-   ##
=======================================
  Coverage   58.90%   58.90%           
=======================================
  Files         477      477           
  Lines       40178    40178           
=======================================
+ Hits        23667    23668    +1     
+ Misses      16511    16510    -1     
Impacted Files Coverage Δ
dart/constraint/ContactConstraint.cpp 72.76% <100.00%> (+0.46%) ⬆️
dart/dynamics/EulerJoint.cpp 70.17% <0.00%> (-2.93%) ⬇️
dart/dynamics/Skeleton.cpp 67.63% <0.00%> (-0.17%) ⬇️
dart/utils/sdf/SdfParser.cpp 76.98% <0.00%> (+0.49%) ⬆️
dart/constraint/ConstraintBase.cpp 75.00% <0.00%> (+20.00%) ⬆️

@costashatz
Copy link
Contributor

costashatz commented Dec 18, 2021

@jslee02 fine for me what you already have! Happy to contribute! Thanks for the awesome library!

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 18, 2021
@azeey
Copy link
Contributor

azeey commented Dec 18, 2021

@jslee02 fine for me what you already have! Happy to contribute! Thanks for the awesome library!

Same here. Thanks for the reviews!

@jslee02 jslee02 merged commit 5df2207 into main Dec 18, 2021
@jslee02 jslee02 deleted the change_log_contribution branch December 18, 2021 15:55
@costashatz
Copy link
Contributor

@jslee02 I just saw that my PR id is wrong. The correct one is #1612.

@jslee02
Copy link
Member Author

jslee02 commented Dec 18, 2021

Oops, fixed in 021dd59

@jslee02 jslee02 changed the title Update changelog and contribution for #1620 and #1624 Update changelog and contribution for #1620 and #1612 Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants