Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory alignment in loading meshes #606

Merged
merged 2 commits into from
Feb 13, 2016
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 10, 2016

This pull request addresses the memory alignment issue with Eigen object in loading meshes, which was reported by @jturner65 in #599.

@mxgrey
Copy link
Member

mxgrey commented Feb 10, 2016

The changes look good 👍, but is there a particular reason that VS can't compile it in release mode? Is it just timing out?

@jslee02
Copy link
Member Author

jslee02 commented Feb 10, 2016

Hm, I'm not sure. Let me make AppVeyor test it again, and test it myself on my virtual machine in parallel to figure it out. I tested it only for debug mode.

@jslee02
Copy link
Member Author

jslee02 commented Feb 10, 2016

I got an error as:

c:\golems\include\eigen\src\core\assign.h(527): fatal error C1002: compiler is out of heap space in pass 2

It seems it needs too much heap memory for 32 bit Windows to build DART. One possible solution would be optimizing the header inclusion as the suggestion of the first answer in this post.

@mxgrey
Copy link
Member

mxgrey commented Feb 10, 2016

It's very likely that our header organization could be improved dramatically, although I'm afraid it might require some refactoring of classes, such as decomposing them into simpler classes and carefully sorting through the dependencies between them.

I don't know who would have time to actually do that, or when.

@jslee02
Copy link
Member Author

jslee02 commented Feb 13, 2016

Yeah, we should give it a try to improve the header organization at some point, but not now. I'm merging this PR, and creating a new issue for this build failure that might be related to the header organization.

jslee02 added a commit that referenced this pull request Feb 13, 2016
Fix memory alignment in loading meshes
@jslee02 jslee02 merged commit 388b847 into release-5.1 Feb 13, 2016
@jslee02 jslee02 deleted the fix_memory_alignment branch February 16, 2016 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants