Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Avoid Using Hardcode ChainId for Internal Transaction #1318

Merged
merged 4 commits into from
Jul 4, 2022
Merged

Avoid Using Hardcode ChainId for Internal Transaction #1318

merged 4 commits into from
Jul 4, 2022

Conversation

boundless-forest
Copy link
Member

@boundless-forest boundless-forest linked an issue Jul 4, 2022 that may be closed by this pull request
Review chain_id settings in ethereum transact, should follow EIP 155 #1273
Closed
@xiaoch05 xiaoch05 mentioned this pull request Jul 4, 2022
Merged
@AurevoirXavier AurevoirXavier changed the title Avoid hardcoding ChainId for the internal transaction Avoid Using Hardcode ChainId for Internal Transaction Jul 4, 2022
@hackfisher
Copy link
Contributor

And please fix the tests @AsceticBear

@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

Commit b36720a

Pangolin

Check Runtime Version

​

Check Storage Prefix

​

Pangoro

Check Runtime Version

​

Check Storage Prefix

​
Commit 173d229

Pangolin

Check Runtime Version

​

Check Storage Prefix

​

Pangoro

Check Runtime Version

​

Check Storage Prefix

​

@hackfisher hackfisher merged commit 9d2a1fa into main Jul 4, 2022
@hackfisher hackfisher deleted the bear-fix-internal-transaction-chain_id branch July 4, 2022 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hackfisher hackfisher hackfisher left review comments

@AurevoirXavier AurevoirXavier AurevoirXavier approved these changes

@xiaoch05 xiaoch05 Awaiting requested review from xiaoch05

Assignees

@boundless-forest boundless-forest

Labels
None yet
Projects
No open projects
Darwinia Release
Status: Done/No Companion
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review chain_id settings in ethereum transact, should follow EIP 155
4 participants
@boundless-forest @hackfisher @xiaoch05 @AurevoirXavier