feat: Allow more characters for asset file names (DEV-4082) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow `+=?!<>|` * Add more tests for letters of other alphabets add more tests
seakayone
requested review from
BalduinLandolt,
mpro7 and
siers
as code owners
seakayone
changed the title
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
siers
approved these changes
Sep 5, 2024
mpro7
approved these changes
Sep 6, 2024
jnussbaum
reviewed
Sep 11, 2024
derschnee68
pushed a commit
that referenced
this pull request
Sep 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.3...v0.13.0) (2024-09-12) ### Maintenances * Dependency updates ([#263](#263)) ([13d0dac](13d0dac)) * Improve Release Please prefixes and corresponding CHANGELOG sections ([#265](#265)) ([b0972c1](b0972c1)) * Minor dependency updates ([#262](#262)) ([2e28360](2e28360)) * Patch dependency updates ([#261](#261)) ([8b5e920](8b5e920)) ### Enhancements * Allow more characters for asset file names (DEV-4082) ([#266](#266)) ([332b519](332b519)) * Download original asset (DEV-3832) ([#267](#267)) ([2c0b3bf](2c0b3bf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+=?!<>|add more tests