Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(excel2json-lists): remove file hierarchy from code #1094

Merged
merged 2 commits into from
Aug 12, 2024
Merged

refactor(excel2json-lists): remove file hierarchy from code #1094

merged 2 commits into from
Aug 12, 2024

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Aug 9, 2024
@Nora-Olivia-Ammann Nora-Olivia-Ammann changed the title refacor(excel2json-lists): remove file hierarchy from code refactor(excel2json-lists): remove file hierarchy from code Aug 9, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.80952% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (56bd84d) to head (6ddcc67).

Files Patch % Lines
src/dsp_tools/commands/excel2json/new_lists.py 98.80% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jnussbaum
jnussbaum approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@jnussbaum jnussbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/unittests/commands/excel2json/test_new_lists.py Show resolved Hide resolved
@Nora-Olivia-Ammann Nora-Olivia-Ammann merged commit 3b554a3 into main Aug 12, 2024
14 of 15 checks passed
@Nora-Olivia-Ammann Nora-Olivia-Ammann deleted the wip/excel2json-lists-remove-file-hierarchy branch August 12, 2024 06:58
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnussbaum jnussbaum jnussbaum approved these changes

Assignees

@Nora-Olivia-Ammann Nora-Olivia-Ammann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nora-Olivia-Ammann @jnussbaum