This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
fix: stream.cancel were causing double-free and segfault
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Werner
previously approved these changes
Sep 30, 2021
Alex-Werner
force-pushed
the
fix/grpc-double-free
branch
2 times, most recently
from
e15407e
to
ee3989c
Compare
shumkov
reviewed
Oct 4, 2021
Alex-Werner
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Due to a bug in
grpc-jsexplained here. A temporary solution is used to bypass this bug until a fix is merged into Node.js explained hereWhat was done?
stream.cancelintosetImmediateHow Has This Been Tested?
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only